Re: [Qemu-devel] [PATCH v2 for-2.3 1/5] hw: Mark devices picking up block backends actively FIXME

[Paolo Bonzini <pbonzini@redhat.com>]

On 25/03/2015 16:17, Andreas Färber wrote:
> > @@ -319,11 +319,13 @@ static void pc87312_realize(DeviceState *dev, Error **errp)
> >          d = DEVICE(isa);
> >          qdev_prop_set_uint32(d, "iobase", get_fdc_iobase(s));
> >          qdev_prop_set_uint32(d, "irq", 6);
> > +        /* FIXME use a qdev drive property instead of drive_get() */
> >          drive = drive_get(IF_FLOPPY, 0, 0);
> >          if (drive != NULL) {
> >              qdev_prop_set_drive_nofail(d, "driveA",
> >                                         blk_by_legacy_dinfo(drive));
> >          }
> > +        /* FIXME use a qdev drive property instead of drive_get() */
> >          drive = drive_get(IF_FLOPPY, 0, 1);
> >          if (drive != NULL) {
> >              qdev_prop_set_drive_nofail(d, "driveB",
>
> As can be seen, there are drive properties driveA and driveB already on
> the destination device. How do you imagine this to be fixed? Add alias
> properties on the container device? (CC'ing Stefan)

Yes, creating the children in pc87312_isa and setting the properties on
pc87312 in the PReP board creation code.

Paolo