From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olliver Schinagl Date: Wed, 25 Mar 2015 15:50:05 +0000 Subject: Re: [PATCHv5 11/11] fbdev: ssd1307fb: Add blank mode Message-Id: <5512D92D.3020809@schinagl.nl> List-Id: References: <1423261694-5939-1-git-send-email-niederp@physik.uni-kl.de> <1427232238-21099-1-git-send-email-niederp@physik.uni-kl.de> <1427232238-21099-12-git-send-email-niederp@physik.uni-kl.de> In-Reply-To: <1427232238-21099-12-git-send-email-niederp@physik.uni-kl.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: =?UTF-8?B?VGhvbWFzIE5pZWRlcnByw7xt?= , plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, maxime.ripard@free-electrons.com, kernel@pengutronix.de, shawn.guo@linaro.org, robh+dt@kernel.org Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Hey Thomas, On 24-03-15 22:23, Thomas Niederprüm wrote: > This patch adds ssd1307fb_blank() to make the framebuffer capable > of blanking. > > Signed-off-by: Thomas Niederprüm > --- > drivers/video/fbdev/ssd1307fb.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c > index 061cc95..9101b27 100644 > --- a/drivers/video/fbdev/ssd1307fb.c > +++ b/drivers/video/fbdev/ssd1307fb.c > @@ -238,6 +238,18 @@ static ssize_t ssd1307fb_write(struct fb_info *info, const char __user *buf, > return count; > } > > +static int ssd1307fb_blank(int blank_mode, struct fb_info *info) > +{ > + struct ssd1307fb_par *par = info->par; > + int ret; > + > + if (blank_mode != FB_BLANK_UNBLANK) > + ret = ssd1307fb_write_cmd(par->client, SSD1307FB_DISPLAY_OFF); > + else > + ret = ssd1307fb_write_cmd(par->client, SSD1307FB_DISPLAY_ON); I'd probably add an extra return, or drop the ret var at all and just return the function. or even shorter :) return sd1307fb_write_cmd(par->client, (blank_mode != FB_BLANK_UNBLANK) ? SSD1307FB_DISPLAY_OFF : SSD1307FB_DISPLAY_ON; Olliver > + return ret; > +} > + > static void ssd1307fb_fillrect(struct fb_info *info, const struct fb_fillrect *rect) > { > struct ssd1307fb_par *par = info->par; > @@ -263,6 +275,7 @@ static struct fb_ops ssd1307fb_ops = { > .owner = THIS_MODULE, > .fb_read = fb_sys_read, > .fb_write = ssd1307fb_write, > + .fb_blank = ssd1307fb_blank, > .fb_fillrect = ssd1307fb_fillrect, > .fb_copyarea = ssd1307fb_copyarea, > .fb_imageblit = ssd1307fb_imageblit, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754595AbbCYPuQ (ORCPT ); Wed, 25 Mar 2015 11:50:16 -0400 Received: from 7of9.schinagl.nl ([88.159.158.68]:45802 "EHLO 7of9.schinagl.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754552AbbCYPuK (ORCPT ); Wed, 25 Mar 2015 11:50:10 -0400 Message-ID: <5512D92D.3020809@schinagl.nl> Date: Wed, 25 Mar 2015 16:50:05 +0100 From: Olliver Schinagl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0 MIME-Version: 1.0 Newsgroups: gmane.linux.kernel To: =?UTF-8?B?VGhvbWFzIE5pZWRlcnByw7xt?= , plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, maxime.ripard@free-electrons.com, kernel@pengutronix.de, shawn.guo@linaro.org, robh+dt@kernel.org CC: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv5 11/11] fbdev: ssd1307fb: Add blank mode References: <1423261694-5939-1-git-send-email-niederp@physik.uni-kl.de> <1427232238-21099-1-git-send-email-niederp@physik.uni-kl.de> <1427232238-21099-12-git-send-email-niederp@physik.uni-kl.de> In-Reply-To: <1427232238-21099-12-git-send-email-niederp@physik.uni-kl.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Thomas, On 24-03-15 22:23, Thomas Niederprüm wrote: > This patch adds ssd1307fb_blank() to make the framebuffer capable > of blanking. > > Signed-off-by: Thomas Niederprüm > --- > drivers/video/fbdev/ssd1307fb.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c > index 061cc95..9101b27 100644 > --- a/drivers/video/fbdev/ssd1307fb.c > +++ b/drivers/video/fbdev/ssd1307fb.c > @@ -238,6 +238,18 @@ static ssize_t ssd1307fb_write(struct fb_info *info, const char __user *buf, > return count; > } > > +static int ssd1307fb_blank(int blank_mode, struct fb_info *info) > +{ > + struct ssd1307fb_par *par = info->par; > + int ret; > + > + if (blank_mode != FB_BLANK_UNBLANK) > + ret = ssd1307fb_write_cmd(par->client, SSD1307FB_DISPLAY_OFF); > + else > + ret = ssd1307fb_write_cmd(par->client, SSD1307FB_DISPLAY_ON); I'd probably add an extra return, or drop the ret var at all and just return the function. or even shorter :) return sd1307fb_write_cmd(par->client, (blank_mode != FB_BLANK_UNBLANK) ? SSD1307FB_DISPLAY_OFF : SSD1307FB_DISPLAY_ON; Olliver > + return ret; > +} > + > static void ssd1307fb_fillrect(struct fb_info *info, const struct fb_fillrect *rect) > { > struct ssd1307fb_par *par = info->par; > @@ -263,6 +275,7 @@ static struct fb_ops ssd1307fb_ops = { > .owner = THIS_MODULE, > .fb_read = fb_sys_read, > .fb_write = ssd1307fb_write, > + .fb_blank = ssd1307fb_blank, > .fb_fillrect = ssd1307fb_fillrect, > .fb_copyarea = ssd1307fb_copyarea, > .fb_imageblit = ssd1307fb_imageblit, >