From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86/MSI: fix error handling
Date: Wed, 25 Mar 2015 18:37:28 +0000 [thread overview]
Message-ID: <55130068.7010308@citrix.com> (raw)
In-Reply-To: <5512EF2F020000780006D8F3@mail.emea.novell.com>
On 25/03/15 16:23, Jan Beulich wrote:
> __setup_msi_irq() needs to undo what it did before calling
> write_msi_msg() in case that returned an error.
>
> map_domain_pirq() needs to get rid of the MSI descriptor it
> (implicitly) allocated. The case of a setup_msi_irq() failure on a
> non-initial multi-vector-MSI interrupt needs special handling: While
> the initial IRQ will get freed by the caller (who also passed it to
> us), we need to undo the effect setup_msi_irq() had on it. (As a
> benefit from the added call to msi_free_irq() we no longer need to
> explicitly call destroy_irq() on the non-initial slots.)
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
prev parent reply other threads:[~2015-03-25 18:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 16:23 [PATCH] x86/MSI: fix error handling Jan Beulich
2015-03-25 18:37 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55130068.7010308@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.