From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 10/12] xen: arm: handle remaining traps from userspace Date: Wed, 25 Mar 2015 19:29:43 +0000 Message-ID: <55130CA7.5050806@linaro.org> References: <1427293339.10784.83.camel@citrix.com> <1427293356-5714-10-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1427293356-5714-10-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 25/03/15 14:22, Ian Campbell wrote: > CP14 dbg and general CP register access are both handled with > unconditional injection of #undef from their respective handlers, so > allow these even from 32-bit userspace on a 64-bit kernel. > > SMC32 and HVC32 should only come from a guest in AArch32 mode and > SMC64 and HVC64 should only come from a guest in AArch64 mode. Add > appropriate BUG_ONs to all cases. > > After this bad_trap is no longer used. > > Signed-off-by: Ian Campbell Reviewed-by: Julien Grall Regards, -- Julien Grall