From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 3/3] xen: arm: handle thumb mode guest in continuations Date: Wed, 25 Mar 2015 23:33:01 +0000 Message-ID: <551345AD.5020608@linaro.org> References: <1427297660-26447-3-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1427297660-26447-3-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 25/03/2015 15:34, Ian Campbell wrote: > PC only needs adjusting by 2, otherwise we rerun the instruction prior > to the hvc as well. I don't understand why you have to adjust PC by 2 for thumb. The spec encodes the HVC thumb instruction on 32 bits (i.e 4 bytes). Regards, -- Julien Grall