From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1Yb264-0000ag-I5
	for qemu-devel@nongnu.org; Thu, 26 Mar 2015 03:20:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1Yb260-0007m4-DS
	for qemu-devel@nongnu.org; Thu, 26 Mar 2015 03:20:56 -0400
Message-ID: <5513B40A.4050104@cn.fujitsu.com>
Date: Thu, 26 Mar 2015 15:23:54 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <1427276174-9130-1-git-send-email-wency@cn.fujitsu.com>
	<1427276174-9130-9-git-send-email-wency@cn.fujitsu.com>
	<20150326070725.GI14724@ad.nay.redhat.com>
	<5513B1BB.5040303@cn.fujitsu.com>
	<20150326071815.GB1035@ad.nay.redhat.com>
In-Reply-To: <20150326071815.GB1035@ad.nay.redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup
 jobs when opening BDS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Lai Jiangshan <laijs@cn.fujitsu.com>, qemu block <qemu-block@nongnu.org>, Jeff Cody <jcody@redhat.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu devel <qemu-devel@nongnu.org>, Gonglei <arei.gonglei@huawei.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Max Reitz <mreitz@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>

On 03/26/2015 03:18 PM, Fam Zheng wrote:
> On Thu, 03/26 15:14, Wen Congyang wrote:
>> On 03/26/2015 03:07 PM, Fam Zheng wrote:
>>> On Wed, 03/25 17:36, Wen Congyang wrote:
>>>> When opening BDS, we need to create backup jobs for
>>>> image-fleecing.
>>>
>>> How does this commit message relate to the Makefile change?
>>
>> Hmm, we need to use backup API in block.c, and block.o will
>> be used by qemu-img which doesn't use common-obj.
> 
> I see. How about adding the referenced functions to stubs/?

Good idea. I will try it.

Thanks
Wen Congyang

> 
> Fam
> 
>>
>> Thanks
>> Wen Congyang
>>
>>>
>>>>
>>>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>>>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>>>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>>>> Cc: Jeff Cody <jcody@redhat.com>
>>>> ---
>>>>  block/Makefile.objs | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/block/Makefile.objs b/block/Makefile.objs
>>>> index db2933e..0950973 100644
>>>> --- a/block/Makefile.objs
>>>> +++ b/block/Makefile.objs
>>>> @@ -21,10 +21,10 @@ block-obj-$(CONFIG_ARCHIPELAGO) += archipelago.o
>>>>  block-obj-$(CONFIG_LIBSSH2) += ssh.o
>>>>  block-obj-y += accounting.o
>>>>  block-obj-y += write-threshold.o
>>>> +block-obj-y += backup.o
>>>>  
>>>>  common-obj-y += stream.o
>>>>  common-obj-y += commit.o
>>>> -common-obj-y += backup.o
>>>>  
>>>>  iscsi.o-cflags     := $(LIBISCSI_CFLAGS)
>>>>  iscsi.o-libs       := $(LIBISCSI_LIBS)
>>>> -- 
>>>> 2.1.0
>>>>
>>> .
>>>
>>
> .
>