From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Date: Thu, 26 Mar 2015 09:29:35 +0000 Subject: Re: [PATCH 4/5] UBI: fix check for "too many bytes" Message-Id: <5513D17F.2080309@nod.at> List-Id: References: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com> <1425119009-28634-5-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1425119009-28634-5-git-send-email-computersforpeace@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Brian Norris , Artem Bityutskiy Cc: kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Am 28.02.2015 um 11:23 schrieb Brian Norris: > The comparison from the previous line seems to have been erroneously > (partially) copied-and-pasted onto the next. The second line should be > checking req.bytes, not req.lnum. > > Coverity CID #139400 > > Signed-off-by: Brian Norris > --- > drivers/mtd/ubi/cdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c > index d647e504f9b1..7691a2a015cb 100644 > --- a/drivers/mtd/ubi/cdev.c > +++ b/drivers/mtd/ubi/cdev.c > @@ -455,7 +455,7 @@ static long vol_cdev_ioctl(struct file *file, unsigned int cmd, > /* Validate the request */ > err = -EINVAL; > if (req.lnum < 0 || req.lnum >= vol->reserved_pebs || > - req.bytes < 0 || req.lnum >= vol->usable_leb_size) > + req.bytes < 0 || req.bytes >= vol->usable_leb_size) > break; Testing uncovered an issue with that. The comparison should be "req.bytes > vol->usable_leb_size" as we're allowed to write with usable_leb_size. There is no need to re-send, I'll fix the patch myself. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from a.ns.miles-group.at ([95.130.255.143] helo=radon.swed.at) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yb46y-0006PO-Tp for linux-mtd@lists.infradead.org; Thu, 26 Mar 2015 09:30:01 +0000 Message-ID: <5513D17F.2080309@nod.at> Date: Thu, 26 Mar 2015 10:29:35 +0100 From: Richard Weinberger MIME-Version: 1.0 To: Brian Norris , Artem Bityutskiy Subject: Re: [PATCH 4/5] UBI: fix check for "too many bytes" References: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com> <1425119009-28634-5-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1425119009-28634-5-git-send-email-computersforpeace@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Cc: kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am 28.02.2015 um 11:23 schrieb Brian Norris: > The comparison from the previous line seems to have been erroneously > (partially) copied-and-pasted onto the next. The second line should be > checking req.bytes, not req.lnum. > > Coverity CID #139400 > > Signed-off-by: Brian Norris > --- > drivers/mtd/ubi/cdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c > index d647e504f9b1..7691a2a015cb 100644 > --- a/drivers/mtd/ubi/cdev.c > +++ b/drivers/mtd/ubi/cdev.c > @@ -455,7 +455,7 @@ static long vol_cdev_ioctl(struct file *file, unsigned int cmd, > /* Validate the request */ > err = -EINVAL; > if (req.lnum < 0 || req.lnum >= vol->reserved_pebs || > - req.bytes < 0 || req.lnum >= vol->usable_leb_size) > + req.bytes < 0 || req.bytes >= vol->usable_leb_size) > break; Testing uncovered an issue with that. The comparison should be "req.bytes > vol->usable_leb_size" as we're allowed to write with usable_leb_size. There is no need to re-send, I'll fix the patch myself. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752400AbbCZJ3n (ORCPT ); Thu, 26 Mar 2015 05:29:43 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:65276 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752202AbbCZJ3i (ORCPT ); Thu, 26 Mar 2015 05:29:38 -0400 Message-ID: <5513D17F.2080309@nod.at> Date: Thu, 26 Mar 2015 10:29:35 +0100 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Brian Norris , Artem Bityutskiy CC: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 4/5] UBI: fix check for "too many bytes" References: <1425119009-28634-1-git-send-email-computersforpeace@gmail.com> <1425119009-28634-5-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1425119009-28634-5-git-send-email-computersforpeace@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 28.02.2015 um 11:23 schrieb Brian Norris: > The comparison from the previous line seems to have been erroneously > (partially) copied-and-pasted onto the next. The second line should be > checking req.bytes, not req.lnum. > > Coverity CID #139400 > > Signed-off-by: Brian Norris > --- > drivers/mtd/ubi/cdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c > index d647e504f9b1..7691a2a015cb 100644 > --- a/drivers/mtd/ubi/cdev.c > +++ b/drivers/mtd/ubi/cdev.c > @@ -455,7 +455,7 @@ static long vol_cdev_ioctl(struct file *file, unsigned int cmd, > /* Validate the request */ > err = -EINVAL; > if (req.lnum < 0 || req.lnum >= vol->reserved_pebs || > - req.bytes < 0 || req.lnum >= vol->usable_leb_size) > + req.bytes < 0 || req.bytes >= vol->usable_leb_size) > break; Testing uncovered an issue with that. The comparison should be "req.bytes > vol->usable_leb_size" as we're allowed to write with usable_leb_size. There is no need to re-send, I'll fix the patch myself. Thanks, //richard