From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Markos Chandras <markos.chandras@imgtec.com>, linux-mips@linux-mips.org
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] clocksource: mips-gic-timer: Ensure GIC counter is running
Date: Thu, 26 Mar 2015 10:52:36 +0100 [thread overview]
Message-ID: <5513D6E4.4000101@linaro.org> (raw)
In-Reply-To: <1427113923-9840-3-git-send-email-markos.chandras@imgtec.com>
On 03/23/2015 01:32 PM, Markos Chandras wrote:
> Start the GIC counter after configuring the clocksource since there
> are no guarantees the counter will be running after a CPU reset.
>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: <linux-kernel@vger.kernel.org>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/clocksource/mips-gic-timer.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clocksource/mips-gic-timer.c b/drivers/clocksource/mips-gic-timer.c
> index 3bd31b1321f6..16adbc1fa4c1 100644
> --- a/drivers/clocksource/mips-gic-timer.c
> +++ b/drivers/clocksource/mips-gic-timer.c
> @@ -133,6 +133,9 @@ static void __init __gic_clocksource_init(void)
> clocksource_register_hz(&gic_clocksource, gic_frequency);
>
> gic_clockevent_init();
> +
> + /* And finally start the counter */
> + gic_start_count();
> }
>
> void __init gic_clocksource_init(unsigned int frequency)
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-03-26 9:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 12:32 [PATCH 0/3] GIC counter fixes Markos Chandras
2015-03-23 12:32 ` Markos Chandras
2015-03-23 12:32 ` [PATCH 1/3] irqchip: irq-mips-gic: Add new functions to start/stop the GIC counter Markos Chandras
2015-03-23 12:32 ` Markos Chandras
2015-03-29 20:39 ` Jason Cooper
2015-03-23 12:32 ` [PATCH 2/3] clocksource: mips-gic-timer: Ensure GIC counter is running Markos Chandras
2015-03-23 12:32 ` Markos Chandras
2015-03-26 9:52 ` Daniel Lezcano [this message]
2015-03-23 12:32 ` [PATCH 3/3] MIPS: Malta: malta-time: " Markos Chandras
2015-03-23 12:32 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5513D6E4.4000101@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.