From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752572AbbCZLBz (ORCPT ); Thu, 26 Mar 2015 07:01:55 -0400 Received: from www.linutronix.de ([62.245.132.108]:55601 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbbCZLBw (ORCPT ); Thu, 26 Mar 2015 07:01:52 -0400 Message-ID: <5513E71E.3090501@linutronix.de> Date: Thu, 26 Mar 2015 12:01:50 +0100 From: Holger Dengler Organization: linutronix GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0 MIME-Version: 1.0 To: Daniel Lezcano , linux-kernel@vger.kernel.org CC: Peter Mahler , Juergen Bubeck , Benedikt Spranger , Thomas Gleixner , John Stultz Subject: Re: [PATCH 10/11] clocksource: flexcard: Add basic timestamp counter support References: <1427277120-16924-1-git-send-email-dengler@linutronix.de> <1427277120-16924-11-git-send-email-dengler@linutronix.de> <5513D450.2080609@linaro.org> In-Reply-To: <5513D450.2080609@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On 03/26/2015 10:41 AM, Daniel Lezcano wrote: >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >> index 68161f7..a6b9308 100644 >> --- a/drivers/clocksource/Kconfig >> +++ b/drivers/clocksource/Kconfig >> @@ -250,4 +250,15 @@ config CLKSRC_PXA >> help >> This enables OST0 support available on PXA and SA-11x0 >> platforms. >> + >> +config CLKSRC_FLEXCARD >> + tristate "Support for Flexcard clock function" > > Why do you need this to be a module ? > > The Kconfig policy is to have it selected by the arch Kconfig. > > It should be like: > > config CLKSRC_FLEXCARD > bool > select CLKSRC_MMIO The Flexcard PMC II, which provides this clocksrc functionality, is a PCI card. According to the PMC specs, this card-type is hot-plugable. So this clocksrc is not SoC-related, it's also hot-plugable. Therefore a module-capable driver seems a good solution for me. > > and then the Kconfig for MFD_FLEXCARD selects CLKSRC_FLEXCARD. > Ok, this could be an option to enable the clocksrc feature by default, if MFD_FLEXCARD is selected. >> + depends on MFD_FLEXCARD >> + select CLKSRC_MMIO >> + help >> + This is the clocksource function driver for the >> + Eberspaecher Flexcard PMC II carrier board. The >> + Flexcard provide a Flexray synchronized counter >> + configurable at 1, 10 or 100MHz. >> + >> endmenu -- Kind regards, Holger Dengler