From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2] xen: arm: correctly handle continuations for 64-bit guests
Date: Thu, 26 Mar 2015 11:58:20 +0000 [thread overview]
Message-ID: <5513F45C.50609@linaro.org> (raw)
In-Reply-To: <1427367244-419-1-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 26/03/2015 10:54, Ian Campbell wrote:
> The 64-bit ABI is different to 32-bit:
>
> - uses x16 as the op register rather than r12.
> - arguments in x0..x5 and not r0..r5. Using rN here potentially
> truncates.
> - return value goes in x0, not r0.
>
> Hypercalls can only be made directly from kernel space, so checking
> the domain's size is sufficient.
>
> Spotted due to spurious -EFAULT when destroying a domain, due to the
> hypercall's pointer argument being truncated. I'm unclear why I am
> only seeing this now.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Reviewed-by: Julien Grall <julien.grall@linaro.org>
> ---
> I imagine this needs backporting everywhere...
>
> v2: Pull regs->pc update out of the conditional blocks, no need to
> mess around with thumb.
FWIW, with this change I confirm my Reviewed-by.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-03-26 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 10:54 [PATCH v2] xen: arm: correctly handle continuations for 64-bit guests Ian Campbell
2015-03-26 11:58 ` Julien Grall [this message]
2015-03-30 9:07 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5513F45C.50609@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.