From: Eric Blake <eblake@redhat.com>
To: Gonglei <arei.gonglei@huawei.com>,
Wen Congyang <wency@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>, Fam Zheng <famz@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
qemu block <qemu-block@nongnu.org>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Yang Hongyang <yanghy@cn.fujitsu.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: Re: [Qemu-devel] [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description
Date: Thu, 26 Mar 2015 06:30:40 -0600 [thread overview]
Message-ID: <5513FBF0.3010807@redhat.com> (raw)
In-Reply-To: <5513DF5D.20106@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
On 03/26/2015 04:28 AM, Gonglei wrote:
>>>> Grammar review only (I'll leave the technical review to others)
>>>>
>>>>>> +Copyright Fujitsu, Corp. 2015
>>>>>> +Copyright (c) 2015 Intel Corporation
>>>>>> +Copyright (c) 2015 HUAWEI TECHNOLOGIES CO.,LTD.
>>>>
>>>> Space after comma in English writing.
>> Yes, but I am not sure I can change it. HUAWEI always use this way.
Copyright lines are one thing that I am reluctant to change if it is not
my own line (some companies have policies on how their lines must look,
and I'm not in a position to argue the policy as I am not a lawyer).
>> You can find it in bootdevice.c
Such existing precedence is a strong argument to NOT changing it, at
least for a patch author that is not the copyright owner.
>
> Good catch, Eric is right. I will change all of this writing way in Qemu at 2.4.
So, sounds like such a change would be a separate patch (probably
through the -trivial tree), and cover all files in the repo in one go,
without affecting this series. Such a patch by a copyright owner would
have no problem being accepted, if it is wanted.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-26 12:31 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 9:36 [Qemu-devel] [RFC PATCH COLO v2 00/13] Block replication for continuous checkpoints Wen Congyang
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 01/13] docs: block replication's description Wen Congyang
2015-03-25 15:38 ` [Qemu-devel] [Qemu-block] " Eric Blake
2015-03-26 8:58 ` Wen Congyang
2015-03-26 10:28 ` Gonglei
2015-03-26 12:30 ` Eric Blake [this message]
2015-03-26 12:46 ` Gonglei
2015-03-26 6:31 ` [Qemu-devel] " Fam Zheng
2015-03-26 7:17 ` Wen Congyang
2015-04-03 2:35 ` Wen Congyang
2015-04-03 5:19 ` Fam Zheng
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 02/13] quorum: allow ignoring child errors Wen Congyang
2015-03-25 12:45 ` Paolo Bonzini
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 03/13] NBD client: connect to nbd server later Wen Congyang
2015-03-25 12:46 ` Paolo Bonzini
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 04/13] Add new block driver interfaces to control block replication Wen Congyang
2015-03-25 12:48 ` Paolo Bonzini
2015-03-25 15:43 ` Eric Blake
2015-03-26 7:12 ` Fam Zheng
2015-03-26 7:22 ` Wen Congyang
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 05/13] quorum: implement block driver interfaces for " Wen Congyang
2015-03-25 12:50 ` Paolo Bonzini
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 06/13] NBD client: " Wen Congyang
2015-03-25 12:50 ` Paolo Bonzini
2015-03-26 7:21 ` Fam Zheng
2015-03-26 7:32 ` Wen Congyang
2015-03-27 1:06 ` Fam Zheng
2015-03-27 1:16 ` Wen Congyang
2015-03-27 7:34 ` [Qemu-devel] Use of QERR_ macros and error classes (was: [RFC PATCH COLO v2 06/13] NBD client: implement block driver interfaces for block replication) Markus Armbruster
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 07/13] allow writing to the backing file Wen Congyang
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS Wen Congyang
2015-03-26 7:07 ` Fam Zheng
2015-03-26 7:14 ` Wen Congyang
2015-03-26 7:18 ` Fam Zheng
2015-03-26 7:23 ` Wen Congyang
2015-03-26 13:53 ` Paolo Bonzini
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 09/13] block: Parse "backing_reference" option to reference existing BDS Wen Congyang
2015-03-26 7:31 ` Fam Zheng
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 10/13] Backup: clear all bitmap when doing block checkpoint Wen Congyang
2015-03-25 12:55 ` Paolo Bonzini
2015-03-26 0:59 ` Wen Congyang
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 11/13] qcow2: support colo Wen Congyang
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 12/13] skip nbd_target when starting block replication Wen Congyang
2015-03-26 7:03 ` Fam Zheng
2015-03-26 7:15 ` Wen Congyang
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 13/13] Don't allow a disk use backing reference target Wen Congyang
2015-03-25 12:56 ` [Qemu-devel] [RFC PATCH COLO v2 00/13] Block replication for continuous checkpoints Paolo Bonzini
2015-03-25 14:24 ` Dr. David Alan Gilbert
2015-03-26 2:34 ` Gonglei
2015-07-01 3:09 ` Michael R. Hines
2015-07-01 4:11 ` Wen Congyang
2015-07-01 19:30 ` Michael R. Hines
2015-07-01 19:37 ` Michael R. Hines
2015-07-02 0:58 ` Wen Congyang
2015-07-02 1:43 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5513FBF0.3010807@redhat.com \
--to=eblake@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=famz@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wency@cn.fujitsu.com \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.