Re: [Qemu-devel] [PATCH] configure: Add support for tcmalloc

[Paolo Bonzini <pbonzini@redhat.com>]

On 26/03/2015 13:53, Kevin Wolf wrote:
> Am 26.03.2015 um 04:03 hat Fam Zheng geschrieben:
>> This adds "--enable-tcmalloc" and "--disable-tcmalloc" to allow linking
>> to libtcmalloc from gperftools.
>>
>> tcmalloc is a malloc implementation that works well with threads and is
>> fast, so it is good for performance.
>>
>> It is disabled by default, because the MALLOC_PERTURB_ flag we use in
>> tests doesn't work with tcmalloc. However we can enable tcmalloc
>> specific heap checker and profilers later.
>>
>> An IOPS gain can be observed with virtio-blk-dataplane, other parts of
>> QEMU will directly benefit from it as well:
>>
>> ==========================================================
>>                        glibc malloc
>> ----------------------------------------------------------
>> rw         bs         iodepth    bw     iops       latency
>> read       4k         1          150    38511      24
>> ----------------------------------------------------------
>>
>> ==========================================================
>>                          tcmalloc
>> ----------------------------------------------------------
>> rw         bs         iodepth    bw     iops       latency
>> read       4k         1          156    39969      23
>> ----------------------------------------------------------
>>
>> Signed-off-by: Fam Zheng <famz@redhat.com>
>> ---
>>  configure | 24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> diff --git a/configure b/configure
>> index 589798e..03ba305 100755
>> --- a/configure
>> +++ b/configure
>> @@ -336,6 +336,7 @@ libssh2=""
>>  vhdx=""
>>  quorum=""
>>  numa=""
>> +tcmalloc="no"
>>  
>>  # parse CC options first
>>  for opt do
>> @@ -1134,6 +1135,10 @@ for opt do
>>    ;;
>>    --enable-numa) numa="yes"
>>    ;;
>> +  --disable-tcmalloc) tcmalloc="no"
>> +  ;;
>> +  --enable-tcmalloc) tcmalloc="yes"
>> +  ;;
>>    *)
>>        echo "ERROR: unknown option $opt"
>>        echo "Try '$0 --help' for more information"
>> @@ -1407,6 +1412,8 @@ Advanced options (experts only):
>>    --enable-quorum          enable quorum block filter support
>>    --disable-numa           disable libnuma support
>>    --enable-numa            enable libnuma support
>> +  --disable-tcmalloc       disable tcmalloc support
>> +  --enable-numa            enable tcmalloc support
> 
> Almost. :-)

Will fix and apply for 2.4.

Paolo