From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [V6 PATCH 2/3] ACPI / scan: Add support for ACPI _CLS device matching Date: Thu, 26 Mar 2015 09:39:48 -0500 Message-ID: <55141A34.6030402@amd.com> References: <1427316368-20965-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1427316368-20965-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20150326102941.GF1878@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-by2on0136.outbound.protection.outlook.com ([207.46.100.136]:33856 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752135AbbCZOj5 (ORCPT ); Thu, 26 Mar 2015 10:39:57 -0400 In-Reply-To: <20150326102941.GF1878@lahna.fi.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Mika Westerberg Cc: rjw@rjwysocki.net, robert.moore@intel.com, lv.zheng@intel.com, lenb@kernel.org, hdegoede@redhat.com, tj@kernel.org, mjg59@srcf.ucam.org, gregkh@linuxfoundation.org, hanjun.guo@linaro.org, al.stone@linaro.org, graeme.gregory@linaro.org, leo.duran@amd.com, linux-ide@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org On 3/26/15 05:29, Mika Westerberg wrote: > On Wed, Mar 25, 2015 at 03:46:07PM -0500, Suravee Suthikulpanit wrote: >> [...] >> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h >> index e530533..9563abe 100644 >> --- a/include/linux/mod_devicetable.h >> +++ b/include/linux/mod_devicetable.h >> @@ -189,8 +189,12 @@ struct css_device_id { >> struct acpi_device_id { >> __u8 id[ACPI_ID_LEN]; >> kernel_ulong_t driver_data; >> + __u32 cls; >> + __u32 cls_msk; >> }; >> >> +#define ACPI_DEVICE_CLASS(cls, msk) "", 0, cls, msk > > Consider moving this to , just like PCI_DEVICE_CLASS() is > defined in . > > Also please use designated initializers here, eg: > > #define ACPI_DEVICE_CLASS(cls, msk) .cls = (cls), .cls_mask = (msk) > > Once done you can add my, > > Acked-by: Mika Westerberg Ah right. I should have done that. I'll send out V7 with this change and acked-by. Thanks, Suravee > >> + >> #define PNP_ID_LEN 8 >> #define PNP_MAX_DEVICES 8 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932088AbbCZOkA (ORCPT ); Thu, 26 Mar 2015 10:40:00 -0400 Received: from mail-by2on0136.outbound.protection.outlook.com ([207.46.100.136]:33856 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752135AbbCZOj5 (ORCPT ); Thu, 26 Mar 2015 10:39:57 -0400 X-WSS-ID: 0NLTQ2B-08-M2K-02 X-M-MSG: Message-ID: <55141A34.6030402@amd.com> Date: Thu, 26 Mar 2015 09:39:48 -0500 From: Suravee Suthikulpanit User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mika Westerberg CC: , , , , , , , , , , , , , , , Subject: Re: [V6 PATCH 2/3] ACPI / scan: Add support for ACPI _CLS device matching References: <1427316368-20965-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1427316368-20965-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20150326102941.GF1878@lahna.fi.intel.com> In-Reply-To: <20150326102941.GF1878@lahna.fi.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; intel.com; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(428002)(24454002)(189002)(164054003)(199003)(479174004)(51704005)(2950100001)(92566002)(101416001)(53416004)(23746002)(86362001)(50466002)(87936001)(65806001)(36756003)(47776003)(106466001)(65956001)(77096005)(62966003)(77156002)(105586002)(110136001)(83506001)(80316001)(19580405001)(19580395003)(46102003)(64126003)(50986999)(87266999)(54356999)(76176999)(65816999)(33656002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR02MB1316;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB1316;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB1378; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:BY2PR02MB1316;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB1316; X-Forefront-PRVS: 0527DFA348 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2015 14:39:51.3686 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB1316 X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/26/15 05:29, Mika Westerberg wrote: > On Wed, Mar 25, 2015 at 03:46:07PM -0500, Suravee Suthikulpanit wrote: >> [...] >> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h >> index e530533..9563abe 100644 >> --- a/include/linux/mod_devicetable.h >> +++ b/include/linux/mod_devicetable.h >> @@ -189,8 +189,12 @@ struct css_device_id { >> struct acpi_device_id { >> __u8 id[ACPI_ID_LEN]; >> kernel_ulong_t driver_data; >> + __u32 cls; >> + __u32 cls_msk; >> }; >> >> +#define ACPI_DEVICE_CLASS(cls, msk) "", 0, cls, msk > > Consider moving this to , just like PCI_DEVICE_CLASS() is > defined in . > > Also please use designated initializers here, eg: > > #define ACPI_DEVICE_CLASS(cls, msk) .cls = (cls), .cls_mask = (msk) > > Once done you can add my, > > Acked-by: Mika Westerberg Ah right. I should have done that. I'll send out V7 with this change and acked-by. Thanks, Suravee > >> + >> #define PNP_ID_LEN 8 >> #define PNP_MAX_DEVICES 8