All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Jan Vesely <jan.vesely@rutgers.edu>, dri-devel@lists.freedesktop.org
Cc: emil.l.velikov@gmail.com
Subject: Re: [PATCH libdrm 2/3] tests/drmsl: Extract tests out of xf86drmSL.c
Date: Thu, 26 Mar 2015 14:49:52 +0000	[thread overview]
Message-ID: <55141C90.3040305@gmail.com> (raw)
In-Reply-To: <1427238406-25103-1-git-send-email-jan.vesely@rutgers.edu>

On 24/03/15 23:06, Jan Vesely wrote:
> v2: merge tests creation and xf86drmSL cleanup
>     rename tests/drmsltest -> tests/drmsl
>     move the test out of libudev test block
> 
> Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
> ---
> 
> Hi Emil,
> I know you send your R-b on the earlier version, but I thought the changes
> were big enough to send v2. I modeled it after you test splitting series.
> 
> jan
> 
>  .gitignore        |   1 +
>  tests/Makefile.am |   5 +-
>  tests/drmsl.c     | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  xf86drmSL.c       | 172 ++----------------------------------------------------
>  4 files changed, 183 insertions(+), 167 deletions(-)
>  create mode 100644 tests/drmsl.c
> 
> diff --git a/.gitignore b/.gitignore
> index 06cc928..cb7128d 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -74,6 +74,7 @@ tdfx.kld
>  via.kld
>  tests/auth
>  tests/dristat
> +tests/drmsl
>  tests/drmstat
>  tests/getclient
>  tests/getstats
Hmm this reminds me that I missed out updating the .gitignore with my
series.

> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 10f54e3..ad70314 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -35,6 +35,9 @@ if HAVE_NOUVEAU
>  SUBDIRS += nouveau
>  endif
>  
> +TESTS = \
> +	drmsl
> +
>  if HAVE_LIBUDEV
>  
>  check_LTLIBRARIES = libdrmtest.la
> @@ -52,7 +55,7 @@ XFAIL_TESTS =					\
>  	auth					\
>  	lock
>  
> -TESTS =						\
> +TESTS +=					\
>  	openclose				\
>  	getversion				\
>  	getclient				\
You will need the following hunk, otherwise drmsl will not end up in the
check target. Although when I think about it there isn't much value in
running this at make check time. I'll leave the decision up-to you.

--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -61,6 +61,7 @@ TESTS =                                               \
        updatedraw                              \
        name_from_fd

+endif
+
 check_PROGRAMS += $(TESTS)

-endif


As before haven't explicitly checked the moved code so

Acked-by: Emil Velikov <emil.l.velikov@gmail.com>

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-03-26 14:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 22:10 [PATCH libdrm 1/4] drmSL: Fix neighbor printing Jan Vesely
2015-03-20 22:10 ` [PATCH libdrm 2/4] drmSL: Split tests to a separate file Jan Vesely
2015-03-22 15:18   ` Emil Velikov
2015-03-24 23:06     ` [PATCH libdrm 2/3] tests/drmsl: Extract tests out of xf86drmSL.c Jan Vesely
2015-03-26 14:49       ` Emil Velikov [this message]
2015-03-20 22:10 ` [PATCH libdrm 3/4] drmsltest: Check expected neighbours Jan Vesely
2015-03-20 22:10 ` [PATCH libdrm 4/4] drmSL: Remove test parts Jan Vesely
2015-03-22 15:22   ` Emil Velikov
2015-03-22 15:13 ` [PATCH libdrm 1/4] drmSL: Fix neighbor printing Emil Velikov
2015-03-24 23:16   ` [PATCH libdrm v3 1/3] drmSL: Fix neighbor lookup Jan Vesely
2015-03-26 14:53     ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55141C90.3040305@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jan.vesely@rutgers.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.