From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [RFC v1 03/15] vmx: Extend struct pi_desc to
 support VT-d Posted-Interrupts
Date: Thu, 26 Mar 2015 18:37:00 +0000
Message-ID: <551451CC.70106@citrix.com>
References: <1427286717-4093-1-git-send-email-feng.wu@intel.com>
	<1427286717-4093-4-git-send-email-feng.wu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1427286717-4093-4-git-send-email-feng.wu@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Feng Wu <feng.wu@intel.com>, xen-devel@lists.xen.org
Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, keir@xen.org, JBeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

On 25/03/15 12:31, Feng Wu wrote:
> Extend struct pi_desc according to VT-d Posted-Interrupts Spec.
>
> Signed-off-by: Feng Wu <feng.wu@intel.com>
> ---
>   xen/include/asm-x86/hvm/vmx/vmcs.h | 16 ++++++++++++++--
>   1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/xen/include/asm-x86/hvm/vmx/vmcs.h b/xen/include/asm-x86/hvm/vmx/vmcs.h
> index 6fce6aa..9631461 100644
> --- a/xen/include/asm-x86/hvm/vmx/vmcs.h
> +++ b/xen/include/asm-x86/hvm/vmx/vmcs.h
> @@ -76,8 +76,20 @@ struct vmx_domain {
>   
>   struct pi_desc {
>       DECLARE_BITMAP(pir, NR_VECTORS);
> -    u32 control;
> -    u32 rsvd[7];
> +    union {
> +        struct
> +        {
> +        u64 on     : 1,

Could you put a comment on each line giving the non-abreviated name for 
the fields, similar to ept_entry_t.

> +            sn     : 1,
> +            rsvd_1 : 13,
> +            ndm    : 1,

Which revision of the spec is this from?  The latest spec linked from 
your covering letter still doesn't identify this 'ndm' field.

~Andrew

> +            nv     : 8,
> +            rsvd_2 : 8,
> +            ndst   : 32;
> +        };
> +        u64 control;
> +    };
> +    u32 rsvd[6];
>   } __attribute__ ((aligned (64)));
>   
>   #define ept_get_wl(ept)   ((ept)->ept_wl)