From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [RFC v1 14/15] Suppress posting interrupts when
 'SN' is set
Date: Thu, 26 Mar 2015 20:34:36 +0000
Message-ID: <55146D5C.4000305@citrix.com>
References: <1427286717-4093-1-git-send-email-feng.wu@intel.com>
	<1427286717-4093-15-git-send-email-feng.wu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1427286717-4093-15-git-send-email-feng.wu@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Feng Wu <feng.wu@intel.com>, xen-devel@lists.xen.org
Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, keir@xen.org, JBeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

On 25/03/15 12:31, Feng Wu wrote:
> Currently, we don't support urgent interrupt, all interrupts
> are recognized as non-urgent interrupt, so we cannot send
> posted-interrupt when 'SN' is set.
>
> Signed-off-by: Feng Wu <feng.wu@intel.com>
> ---
>   xen/arch/x86/hvm/vmx/vmx.c | 13 ++++++++++++-
>   1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index 6323bd6..40c7b0e 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -1663,9 +1663,20 @@ static void __vmx_deliver_posted_interrupt(struct vcpu *v)
>   
>   static void vmx_deliver_posted_intr(struct vcpu *v, u8 vector)
>   {
> +    int r, sn;
> +
>       if ( pi_test_and_set_pir(vector, &v->arch.hvm_vmx.pi_desc) )
>           return;
>   
> +    /*
> +     * Currently, we don't support urgent interrupt, all interrupts
> +     * are recognized as non-urgent interrupt, so we cannot send
> +     * posted-interrupt when 'SN' is set.
> +     */
> +
> +    sn = pi_test_sn(&v->arch.hvm_vmx.pi_desc);

Is there anywhere which sets sn at all? I cant spot anywhere.

~Andrew

> +    r = pi_test_and_set_on(&v->arch.hvm_vmx.pi_desc);
> +
>       if ( unlikely(v->arch.hvm_vmx.eoi_exitmap_changed) )
>       {
>           /*
> @@ -1675,7 +1686,7 @@ static void vmx_deliver_posted_intr(struct vcpu *v, u8 vector)
>            */
>           pi_set_on(&v->arch.hvm_vmx.pi_desc);
>       }
> -    else if ( !pi_test_and_set_on(&v->arch.hvm_vmx.pi_desc) )
> +    else if ( !r && !sn )
>       {
>           __vmx_deliver_posted_interrupt(v);
>           return;