From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Programmingkid <programmingkidx@gmail.com>,
anandk1386@gmail.com,
qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-discuss] error - Guest has not initialized the display yet.
Date: Thu, 26 Mar 2015 22:00:31 +0100 [thread overview]
Message-ID: <5514736F.3040605@redhat.com> (raw)
In-Reply-To: <CAFEAcA8coW7vPEL=W20TyBYPYtNBWR9Lj1XdYuZfm7Vt_9T7dw@mail.gmail.com>
On 26/03/2015 21:55, Peter Maydell wrote:
> I feel like we're recapitulating history here -- is
> c3c1bb99d undoing the fix that a87f39543a made for when we
> tried this a year ago in 360e607, or is there something
> more subtle going on ?
It's more subtle. The patch should only make a difference when
address_space_translate_internal modifies *plen.
The crux of the change is the first operand of this MIN:
- len = MIN(len, (addr | iotlb.addr_mask) - addr + 1);
+ *plen = MIN(*plen, (addr | iotlb.addr_mask) - addr + 1);
changing from len to *plen.
Paolo
next prev parent reply other threads:[~2015-03-26 21:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.38957.1427322059.31050.qemu-discuss@nongnu.org>
2015-03-25 23:52 ` [Qemu-devel] [Qemu-discuss] error - Guest has not initialized the display yet Programmingkid
2015-03-26 9:41 ` Peter Maydell
2015-03-26 20:31 ` Mark Cave-Ayland
2015-03-26 20:55 ` Peter Maydell
2015-03-26 21:00 ` Paolo Bonzini [this message]
2015-03-28 20:25 ` Mark Cave-Ayland
2015-03-28 14:50 ` Programmingkid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5514736F.3040605@redhat.com \
--to=pbonzini@redhat.com \
--cc=anandk1386@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.