From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:42156 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbbC0Fsq (ORCPT ); Fri, 27 Mar 2015 01:48:46 -0400 Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1YbN8P-000D37-Fj for linux-watchdog@vger.kernel.org; Fri, 27 Mar 2015 05:48:45 +0000 Message-ID: <5514EF25.4000400@roeck-us.net> Date: Thu, 26 Mar 2015 22:48:21 -0700 From: Guenter Roeck MIME-Version: 1.0 To: Shubhrajyoti Datta , Baruch Siach CC: Wim Van Sebroeck , devicetree@vger.kernel.org, "linux-watchdog@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 2/2] watchdog: digicolor: driver for Conexant Digicolor CX92755 SoC References: <148dd2d6912211bc468c30acf85a463192576039.1427356791.git.baruch@tkos.co.il> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 03/26/2015 10:40 PM, Shubhrajyoti Datta wrote: > > + > +static int dc_restart_handler(struct notifier_block *this, unsigned long mode, > + void *cmd) > +{ > + struct dc_wdt *wdt = container_of(this, struct dc_wdt, restart_handler); > + > + dc_wdt_set(wdt, 1); > + /* wait for reset to assert... */ > + mdelay(500); > > > How is the 500 calculated ? > Also is it possible to sleep here? > sleep: No. It would also be pretty pointless, since this is after all the very last step of rebooting the system. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Thu, 26 Mar 2015 22:48:21 -0700 Subject: [PATCH v2 2/2] watchdog: digicolor: driver for Conexant Digicolor CX92755 SoC In-Reply-To: References: <148dd2d6912211bc468c30acf85a463192576039.1427356791.git.baruch@tkos.co.il> Message-ID: <5514EF25.4000400@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/26/2015 10:40 PM, Shubhrajyoti Datta wrote: > > + > +static int dc_restart_handler(struct notifier_block *this, unsigned long mode, > + void *cmd) > +{ > + struct dc_wdt *wdt = container_of(this, struct dc_wdt, restart_handler); > + > + dc_wdt_set(wdt, 1); > + /* wait for reset to assert... */ > + mdelay(500); > > > How is the 500 calculated ? > Also is it possible to sleep here? > sleep: No. It would also be pretty pointless, since this is after all the very last step of rebooting the system. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v2 2/2] watchdog: digicolor: driver for Conexant Digicolor CX92755 SoC Date: Thu, 26 Mar 2015 22:48:21 -0700 Message-ID: <5514EF25.4000400@roeck-us.net> References: <148dd2d6912211bc468c30acf85a463192576039.1427356791.git.baruch@tkos.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shubhrajyoti Datta , Baruch Siach Cc: Wim Van Sebroeck , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On 03/26/2015 10:40 PM, Shubhrajyoti Datta wrote: > > + > +static int dc_restart_handler(struct notifier_block *this, unsigned long mode, > + void *cmd) > +{ > + struct dc_wdt *wdt = container_of(this, struct dc_wdt, restart_handler); > + > + dc_wdt_set(wdt, 1); > + /* wait for reset to assert... */ > + mdelay(500); > > > How is the 500 calculated ? > Also is it possible to sleep here? > sleep: No. It would also be pretty pointless, since this is after all the very last step of rebooting the system. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html