All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
	xen-devel@lists.xenproject.org
Cc: jgross@suse.com, boris.ostrovsky@oracle.com, mcgrof@suse.com,
	david.vrabel@citrix.com
Subject: Re: [RFT] x86/pvh: disable all MTRR CPU features on cpuid for dom0
Date: Fri, 27 Mar 2015 09:32:10 +0100	[thread overview]
Message-ID: <5515158A.8090604@citrix.com> (raw)
In-Reply-To: <1427412834-4624-1-git-send-email-mcgrof@do-not-panic.com>

El 27/03/15 a les 0.33, Luis R. Rodriguez ha escrit:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> 
> Commit 586ab6a by Roger disabled the main MTRR CPU feature
> on the cpuid when on pvh in order to avoid having MTRR code
> run on the OS on dom0. This missed the fact that not all CPUs
> use this cpuid to identify MTRR support, this complets that.
> 
> This could in theory fix some potential issues where MTRR
> code was previously enabled, for instance running cat /proc/mtrr
> on a Linux system where MTRR was actually disabled.

AFAICT we will never support PVH on those CPU types, so I'm not sure if
it's worth disabling it. AMD K6, Centaur and VIA chips don't have the
necessary hardware extensions to allow running PVH guests.

Roger.

  reply	other threads:[~2015-03-27  8:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 23:33 [RFT] x86/pvh: disable all MTRR CPU features on cpuid for dom0 Luis R. Rodriguez
2015-03-27  8:32 ` Roger Pau Monné [this message]
2015-03-27 18:08   ` Luis R. Rodriguez
2015-03-27  9:37 ` Andrew Cooper
2015-03-27 10:33   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5515158A.8090604@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=jgross@suse.com \
    --cc=mcgrof@do-not-panic.com \
    --cc=mcgrof@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.