From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752573AbbC0KXy (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 Mar 2015 06:23:54 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:12005 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752447AbbC0KXs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 Mar 2015 06:23:48 -0400
X-AuditID: cbfec7f5-b7fc86d0000066b7-47-55152fb0701b
Message-id: <55152FA7.80708@samsung.com>
Date: Fri, 27 Mar 2015 11:23:35 +0100
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.1.2
MIME-version: 1.0
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
        Mike Turquette <mturquette@linaro.org>, Lee Jones <lee@kernel.org>,
        Bryan Huntsman <bryanh@codeaurora.org>,
        Ralf Baechle <ralf@linux-mips.org>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH v3 1/1] clkdev: change prototype of clk_register_clkdev()
References: <1426857509-6297-1-git-send-email-andriy.shevchenko@linux.intel.com>
 <1426857509-6297-2-git-send-email-andriy.shevchenko@linux.intel.com>
In-reply-to: <1426857509-6297-2-git-send-email-andriy.shevchenko@linux.intel.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t/xy7ob9EVDDZ5ONbXobZrOZPHv2BQm
	ix1tC1ksLu+aw2Zx+zKvxZvfL9gtnk64yGZxaY+KxY8z3SwWfWsvsTlweayZt4bRo6W5h83j
	cl8vk8eOu0sYPTat6mTzuHNtD5vH0ZVrmTzmnQz0+LxJLoAzissmJTUnsyy1SN8ugStjyprd
	bAUTuSpWnZrC3sB4hb2LkZNDQsBEYuPtJWwQtpjEhXvrgWwuDiGBpYwSf75+Z4ZwPjFKvNr0
	AayKV0BDYsOsFywgNouAqsTqrhNgNpuAoUTv0T5GEFtUIELi5N097BD1ghI/Jt8DqxERyJBY
	9ugLC8hQZoHdTBLf5n8DGsrBISzgK9HcFQSxbCajxM2rrWDNnALBEi2n/jGD1DAL6Encv6gF
	EmYWkJfYvOYt8wRGgVlIVsxCqJqFpGoBI/MqRtHU0uSC4qT0XCO94sTc4tK8dL3k/NxNjJAo
	+bqDcekxq0OMAhyMSjy8nPUioUKsiWXFlbmHGCU4mJVEeFc+BgrxpiRWVqUW5ccXleakFh9i
	ZOLglGpgVJfzqNwWG9IW9SGoJKjT1+/v7f2drVPvlu/P5ZOX37kgeV3J1otLHp1Ui452zz/4
	8MD3luIUswNhJcVHfOcnTZeZdN1x5RONuju52kr+jZmf12TvW7134s2OJ3Gt8U3xF7+x/z7x
	cLbwmXXW0Rk5c2ZXWzZc1nsh0ceQK3No1oTtss9t3/2ZrsRSnJFoqMVcVJwIAN+9AfVwAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Andy,

On 20/03/15 14:18, Andy Shevchenko wrote:
> Since clk_register_clkdev() is exported for modules the caller should get a
> pointer to the allocated resources. Otherwise the memory leak is guaranteed on
> the ->remove() stage.
> 
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  arch/arm/mach-msm/clock-pcom.c         |  9 +++++----
>  arch/arm/mach-vexpress/spc.c           |  5 ++++-
>  arch/mips/ath79/clock.c                |  6 +++---
>  drivers/clk/clk-bcm2835.c              | 12 +++++++-----
>  drivers/clk/clk-max-gen.c              |  9 ++++-----
>  drivers/clk/clk-xgene.c                |  6 +++---
>  drivers/clk/clkdev.c                   | 15 ++++++++++-----
>  drivers/clk/samsung/clk-pll.c          | 15 +++++++++------
>  drivers/clk/samsung/clk-s3c2410-dclk.c | 22 +++++++++++----------
>  drivers/clk/samsung/clk.c              | 35 +++++++++++++++++++---------------
>  include/linux/clkdev.h                 |  2 +-
>  11 files changed, 78 insertions(+), 58 deletions(-)

I tested this on exynos, for clk/samsung

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

-- 
Thanks,
Sylwester