All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v4] drm/i915: Compare GGTT view structs instead of types
Date: Fri, 27 Mar 2015 11:46:24 +0000	[thread overview]
Message-ID: <55154310.40006@linux.intel.com> (raw)
In-Reply-To: <1427454562.4966.10.camel@jlahtine-mobl1>


Hi,

On 03/27/2015 11:09 AM, Joonas Lahtinen wrote:
> To allow for views where the view type is not defined by the view type only,
> like it is in stereo or rotated 90 degree view, change the semantic to require
> the whole view structure for comparison when we match a GGTT view.
>
> This allows including parameters like offset to be included in the view which
> is useful for eg. partial views.
>
> v3:
> - Rely on ggtt_view type being 0 for non-GGTT vma's, which equals to
>    I915_GGTT_VIEW_NORMAL. (Daniel Vetter)
> - Do not use potentially slower comparison when we only want to know if
>    something is or is not a normal view.
> - Rebase on top of rotated view patches. Add rotated view singleton.
> - If one view is missing in comparison they're equal only if both are missing.
>
> v4:
> - Use comparison helper in obj_to_ggtt_view too. (Tvrtko Ursulin)
> - Do WARN_ON if one view is NULL. (Tvrtko Ursulin)
>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> (v2)
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-03-27 11:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 12:51 [PATCH v2] drm/i915: Compare GGTT view structs instead of types Joonas Lahtinen
2015-03-23 13:39 ` Tvrtko Ursulin
2015-03-24 12:45   ` Joonas Lahtinen
2015-03-25 10:59   ` Daniel Vetter
2015-03-27 10:03     ` [PATCH v3] " Joonas Lahtinen
2015-03-27 10:41       ` Tvrtko Ursulin
2015-03-27 11:09         ` [PATCH v4] " Joonas Lahtinen
2015-03-27 11:46           ` Tvrtko Ursulin [this message]
2015-03-27 14:05             ` Daniel Vetter
2015-03-27 15:32           ` shuang.he
2015-03-27 13:22       ` [PATCH v3] " shuang.he
2015-03-24 18:18 ` [PATCH v2] " shuang.he

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55154310.40006@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.