From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932178AbbC0M2E (ORCPT ); Fri, 27 Mar 2015 08:28:04 -0400 Received: from www.linutronix.de ([62.245.132.108]:60508 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932165AbbC0M2A (ORCPT ); Fri, 27 Mar 2015 08:28:00 -0400 Message-ID: <55154CCD.9070402@linutronix.de> Date: Fri, 27 Mar 2015 13:27:57 +0100 From: Holger Dengler Organization: linutronix GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0 MIME-Version: 1.0 To: John Stultz CC: Daniel Lezcano , lkml , Peter Mahler , Juergen Bubeck , Benedikt Spranger , Thomas Gleixner Subject: Re: [PATCH 10/11] clocksource: flexcard: Add basic timestamp counter support References: <1427277120-16924-1-git-send-email-dengler@linutronix.de> <1427277120-16924-11-git-send-email-dengler@linutronix.de> <5513D450.2080609@linaro.org> <5513E71E.3090501@linutronix.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, On 03/26/2015 05:34 PM, John Stultz wrote: > On Thu, Mar 26, 2015 at 4:01 AM, Holger Dengler wrote: >> On 03/26/2015 10:41 AM, Daniel Lezcano wrote: >>> >>> config CLKSRC_FLEXCARD >>> bool >>> select CLKSRC_MMIO >> >> The Flexcard PMC II, which provides this clocksrc functionality, is a >> PCI card. According to the PMC specs, this card-type is hot-plugable. So >> this clocksrc is not SoC-related, it's also hot-plugable. >> Therefore a module-capable driver seems a good solution for me. >> >>> >>> and then the Kconfig for MFD_FLEXCARD selects CLKSRC_FLEXCARD. >>> >> >> Ok, this could be an option to enable the clocksrc feature by default, >> if MFD_FLEXCARD is selected. > > Yea, I think this would be preferred. If the user already selects > something to get device functionality, lets not make them search > around in other menus to find another config option to enable all the > capabilities. We integrated the "MFD_FLEXCARD selects CLKSRC_FLEXCARD". If we get some responces as well for the other parts of this patchset, we'll resend it with the modifications. > > thanks > -john > Kind regards, Holger Dengler -- phone: +49 7556 45 218 94; fax: +49 7556 91 98 86