From: Julien Grall <julien.grall@linaro.org>
To: Manish Jaggi <mjaggi@caviumnetworks.com>,
Xen Devel <xen-devel@lists.xen.org>,
"Prasun.kapoor@cavium.com" <Prasun.kapoor@cavium.com>,
"Kumar, Vijaya" <Vijaya.Kumar@caviumnetworks.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain
Date: Fri, 27 Mar 2015 13:04:23 +0000 [thread overview]
Message-ID: <55155557.7020103@linaro.org> (raw)
In-Reply-To: <551505B3.9020505@caviumnetworks.com>
Hi manish,
On 27/03/15 07:24, Manish Jaggi wrote:
> It is good for code readability as there are many structures ending with
> the name domain.
> Also a code like this one is now easy to understand with the rename
> old: dev_iommu_domain(dev) = domain;
> new: dev_iommu_domain(dev) = iommu_domain;
>
> Also in current code struct smmu_domain pointer variable name is always
> smmu_domain.
> The change is on the same lines
You are modifying the code from Linux just for your own comprehension.
And we are trying to not diverge from a specific Linux commit in order
to easily backport patch.
NAcked-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-03-27 13:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 7:24 [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain Manish Jaggi
2015-03-27 13:04 ` Julien Grall [this message]
2015-03-27 13:26 ` Jaggi, Manish
2015-03-27 13:41 ` Julien Grall
2015-03-27 18:05 ` Jaggi, Manish
2015-03-27 19:20 ` Julien Grall
2015-03-31 16:48 ` Stefano Stabellini
2015-04-01 8:30 ` Ian Campbell
2015-04-06 14:15 ` Julien Grall
2015-04-14 11:15 ` Ian Campbell
2015-04-14 11:46 ` Julien Grall
2015-04-14 12:24 ` Jaggi, Manish
2015-04-14 12:47 ` Julien Grall
2015-04-14 14:19 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55155557.7020103@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=Prasun.kapoor@cavium.com \
--cc=Vijaya.Kumar@caviumnetworks.com \
--cc=mjaggi@caviumnetworks.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.