From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YbUi2-0007uZ-Vm for mharc-grub-devel@gnu.org; Fri, 27 Mar 2015 09:54:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbUhx-0007uK-A6 for grub-devel@gnu.org; Fri, 27 Mar 2015 09:54:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbUhr-0007aa-Ta for grub-devel@gnu.org; Fri, 27 Mar 2015 09:53:57 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:15585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbUhr-0007aD-P5 for grub-devel@gnu.org; Fri, 27 Mar 2015 09:53:51 -0400 X-IronPort-AV: E=Sophos;i="5.11,479,1422921600"; d="scan'208";a="248963629" Message-ID: <551560E8.5020306@citrix.com> Date: Fri, 27 Mar 2015 13:53:44 +0000 From: Andrew Cooper User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0 MIME-Version: 1.0 To: Jan Beulich , Daniel Kiper Subject: Re: [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader References: <1422640462-28103-1-git-send-email-daniel.kiper@oracle.com> <1422640462-28103-6-git-send-email-daniel.kiper@oracle.com> <54E76C2F0200007800062262@mail.emea.novell.com> <20150327133228.GN8294@olila.local.net-space.pl> <55156C7E020000780006E98E@mail.emea.novell.com> In-Reply-To: <55156C7E020000780006E98E@mail.emea.novell.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-DLP: MIA2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.63 Cc: Juergen Gross , grub-devel@gnu.org, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, phcoder@gmail.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2015 13:54:02 -0000 On 27/03/15 13:43, Jan Beulich wrote: >>>> On 27.03.15 at 14:32, wrote: >> On Fri, Feb 20, 2015 at 04:17:35PM +0000, Jan Beulich wrote: >>>>>> On 30.01.15 at 18:54, wrote: >>>> We need more fine grained knowledge about EFI environment and check >>>> for EFI platform and EFI loader separately to properly support >>>> multiboot2 protocol. >>> ... because of ... (i.e. I can't see from the description what the >>> separation is good for). Looking at the comments you placed >>> aside the variables doesn't help me either. >>> >>>> In general Xen loaded by this protocol uses >>>> memory mappings and loaded modules in simliar way to Xen loaded >>>> by multiboot (v1) protocol. Hence, split efi_enabled to efi_platform >>>> and efi_loader. >>> And if I'm guessing things right, then introducing efi_loader but >>> leaving efi_enabled alone (only converting where needed) would >> efi_enabled is not fortunate name for new usage. Currently it means >> that Xen binary have or does not have EFI support build in. However, >> if we build in multiboot2 protocol into xen.gz then it means that >> it can ran on legacy BIOS or EFI platform. So, I think that we >> should rename efi_enabled to efi_platform because it will mean >> that Xen runs on EFI platform or not. > I disagree here. > >> efi_loader is used to differentiate between EFI native loader >> and multiboot2 protocol. > And I agree here. I suppose "built with efi support" is known because of CONFIG_EFI or not, and doesn't need a variable. However, "booted legacy" vs "booted EFI" does need distinguishing at runtime, as either is possible. ~Andrew