From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 04/15] xen: arm: handle accesses to CNTP_CVAL_EL0 Date: Fri, 27 Mar 2015 15:58:35 +0000 Message-ID: <55157E2B.6030908@linaro.org> References: <1427466798.13935.158.camel@citrix.com> <1427466824-31967-4-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1427466824-31967-4-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 27/03/15 14:33, Ian Campbell wrote: > All OSes we have run on top of Xen use CNTP_TVAL_EL0 but for > completeness we really should handle CVAL too. > > In vtimer_emulate_cp64 pull the propagation of the 64-bit result into > two 32-bit registers out of the switch to avoid duplicating for every > register. We also need to initialise x now since previously the only > register implemented register was R/O. > > While adding HSR_SYSREG_CNTP_CVAL_EL0 also move > HSR_SYSREG_CNTP_CTL_EL0 so it is sorted correctly. > > Signed-off-by: Ian Campbell Reviewed-by: Julien Grall Regards, -- Julien Grall