From: Oleksandr G Zhadan <oleks@arcturusnetworks.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mpc85xx gpio related header files changes to compile common cmd_gpio.c
Date: Fri, 27 Mar 2015 12:09:21 -0400 [thread overview]
Message-ID: <551580B1.7020904@arcturusnetworks.com> (raw)
In-Reply-To: <1427471186.13051.66.camel@transmode.se>
Yes, here locally we have some additional changes/fixes in some places
as well. And if talk about mpc85xx gpio support it's better to have
driver in drivers/gpio vs static definitions in header file and I have
it. But currently I need this minimal patch to be accepted to send our
board support patch based on this one.
Oleks
On 03/27/2015 11:46 AM, Joakim Tjernlund wrote:
> On Fri, 2015-03-27 at 10:51 -0400, Oleksandr G Zhadan wrote:
>> Extra gpio bank argument at low level may be discussable, but IMPO we
>> should not brake standard int gpio_set_value(unsigned gpio, int value)
>> definition.
>>
>> And the reason of this patch is to fix:
>>
>> 1. Incompatibility in functions gpio_free() and gpio_set_value()
>> definitions between <asm/gpio.h> and <asm-generic/gpio.h> (void vs int)
>>
>> 2. Compilation error when build common/cmd_gpio.c for mpc85xx (p1020)
>
> Sure, when I saw "mpc85xx gpio .." I remembered seeing this flaw so I figured
> I point it out before I forget again.
>
> This also makes me remember, drivers/spi/fsl_espi.c is broken for anything
> but reading an EEPROM.
>
> Jocke
>
prev parent reply other threads:[~2015-03-27 16:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 21:16 [U-Boot] [PATCH 1/2] mpc85xx gpio related header files changes to compile common cmd_gpio.c Oleksandr G Zhadan
2015-03-26 21:20 ` York Sun
2015-03-27 18:27 ` Oleksandr G Zhadan
2015-03-27 18:44 ` York Sun
2015-03-27 0:26 ` Joakim Tjernlund
2015-03-27 14:51 ` Oleksandr G Zhadan
2015-03-27 15:46 ` Joakim Tjernlund
2015-03-27 16:09 ` Oleksandr G Zhadan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551580B1.7020904@arcturusnetworks.com \
--to=oleks@arcturusnetworks.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.