From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <551587D3.3050200@suse.cz> Date: Fri, 27 Mar 2015 17:39:47 +0100 From: Vlastimil Babka MIME-Version: 1.0 Subject: Re: [PATCH 3/4] mm, shmem: Add shmem resident memory accounting References: <1424958666-18241-1-git-send-email-vbabka@suse.cz> <1424958666-18241-4-git-send-email-vbabka@suse.cz> <54EF34C5.1090007@redhat.com> In-Reply-To: <54EF34C5.1090007@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-Archive: List-Post: To: Jerome Marchand , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-doc@vger.kernel.org, Hugh Dickins , Michal Hocko , "Kirill A. Shutemov" , Cyrill Gorcunov , Randy Dunlap , linux-s390@vger.kernel.org, Martin Schwidefsky , Heiko Carstens , Peter Zijlstra , Paul Mackerras , Arnaldo Carvalho de Melo , Oleg Nesterov List-ID: On 02/26/2015 03:59 PM, Jerome Marchand wrote: > On 02/26/2015 02:51 PM, Vlastimil Babka wrote: >> >> +/* Optimized variant when page is already known not to be PageAnon */ >> +static inline int mm_counter_file(struct page *page) > > Just a nitpick, but I don't like that name as it keeps the confusion we > currently have between shmem and file backed pages. I'm not sure what > other name to use though. mm_counter_shared() maybe? I'm not sure it is > less confusing... I think that's also confusing, but differently. Didn't come up with better name, so leaving as it is for v2. Thanks > Jerome > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753605AbbC0QkO (ORCPT ); Fri, 27 Mar 2015 12:40:14 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45103 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752093AbbC0QkI (ORCPT ); Fri, 27 Mar 2015 12:40:08 -0400 Message-ID: <551587D3.3050200@suse.cz> Date: Fri, 27 Mar 2015 17:39:47 +0100 From: Vlastimil Babka User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Jerome Marchand , linux-mm@kvack.org CC: linux-kernel@vger.kernel.org, Andrew Morton , linux-doc@vger.kernel.org, Hugh Dickins , Michal Hocko , "Kirill A. Shutemov" , Cyrill Gorcunov , Randy Dunlap , linux-s390@vger.kernel.org, Martin Schwidefsky , Heiko Carstens , Peter Zijlstra , Paul Mackerras , Arnaldo Carvalho de Melo , Oleg Nesterov Subject: Re: [PATCH 3/4] mm, shmem: Add shmem resident memory accounting References: <1424958666-18241-1-git-send-email-vbabka@suse.cz> <1424958666-18241-4-git-send-email-vbabka@suse.cz> <54EF34C5.1090007@redhat.com> In-Reply-To: <54EF34C5.1090007@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/2015 03:59 PM, Jerome Marchand wrote: > On 02/26/2015 02:51 PM, Vlastimil Babka wrote: >> >> +/* Optimized variant when page is already known not to be PageAnon */ >> +static inline int mm_counter_file(struct page *page) > > Just a nitpick, but I don't like that name as it keeps the confusion we > currently have between shmem and file backed pages. I'm not sure what > other name to use though. mm_counter_shared() maybe? I'm not sure it is > less confusing... I think that's also confusing, but differently. Didn't come up with better name, so leaving as it is for v2. Thanks > Jerome >