From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC PATCH v2 16/22] xen/arm: its: implement
 hw_irq_controller for LPIs
Date: Fri, 27 Mar 2015 17:02:18 +0000
Message-ID: <55158D1A.8030404@linaro.org>
References: <1426775889-29442-1-git-send-email-vijay.kilari@gmail.com>
	<1426775889-29442-17-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1426775889-29442-17-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

Hello Vijay,

On 19/03/15 14:38, vijay.kilari@gmail.com wrote:
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index 2b406e6..1b3ecd7 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -40,6 +40,7 @@
>  #include <asm/device.h>
>  #include <asm/gic.h>
>  #include <asm/gic_v3_defs.h>
> +#include <asm/gic-its.h>
>  #include <asm/cpufeature.h>
>  
>  struct rdist_region {
> @@ -427,12 +428,18 @@ static void gicv3_poke_irq(struct irq_desc *irqd, u32 offset)
>  
>  static void gicv3_unmask_irq(struct irq_desc *irqd)
>  {
> -    gicv3_poke_irq(irqd, GICD_ISENABLER);
> +    if ( is_lpi(irqd->irq) )
> +        lpi_set_config(irqd, 1);
> +    else
> +        gicv3_poke_irq(irqd, GICD_ISENABLER);
>  }

While Stefano was asking to move the hw_irq_controller in gic-v3.c, I
believe he didn't meant merging them.

The goal of the hw_irq_control is to avoid unnecessary check like the
"if ( is_lpi(...) ) /* LPI handling */ else /* GICv3 handling */"

Regards,

-- 
Julien Grall