From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain Date: Fri, 27 Mar 2015 19:20:59 +0000 Message-ID: <5515AD9B.6060403@linaro.org> References: <551505B3.9020505@caviumnetworks.com>, <55155557.7020103@linaro.org> <1427462781997.9237@caviumnetworks.com>, <55155DF3.7090507@linaro.org> <1427479535775.96644@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1427479535775.96644@caviumnetworks.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Jaggi, Manish" , Xen Devel , "Prasun.kapoor@cavium.com" , "Kumar, Vijaya" , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 27/03/2015 18:05, Jaggi, Manish wrote: > From: Julien Grall > Sent: Friday, March 27, 2015 7:11 PM > To: Jaggi, Manish; Xen Devel; Prasun.kapoor@cavium.com; Kumar, Vijaya; Ian Campbell; Stefano Stabellini > Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain > > On 27/03/15 13:26, Jaggi, Manish wrote: >> On 27/03/15 07:24, Manish Jaggi wrote: >>> It is good for code readability as there are many structures ending with >>> the name domain. >>> Also a code like this one is now easy to understand with the rename >>> old: dev_iommu_domain(dev) = domain; >>> new: dev_iommu_domain(dev) = iommu_domain; >> [manish] Did u see this line > > I don't care about the new vs old stuff. What I care is keeping the code > as close as possible to the Linux code. > > [manish] then you are missing a point my friend. The line mentioned old is not at all intuitive and is confusing. Please avoid familiarity... I'm not my friend and a such things will do the inverse effect you are trying to reach. > I am not proposing a design change. All I am asking to add a prefix to iommu_domain pointers as was already done for smmu_domain pointers. I didn't talk about design change but code modification. If you change the name of variables, it will require more work to backport a patch from Linux because the patch won't apply cleanly. I've spent quite a lots of time to change as little as possible the Linux code and justify any change. You can see the different mail I had with Ian & Stefano for this purpose. IHMO, changing the code just for your own comprehension is not a valid justification. Regards, -- Julien Grall