From: Iain Paton <ipaton0@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] sunxi: sun4i: add missing 912MHz clock divisors
Date: Sat, 28 Mar 2015 10:24:49 +0000 [thread overview]
Message-ID: <55168171.2000200@gmail.com> (raw)
In-Reply-To: <1427465093.13935.151.camel@hellion.org.uk>
On 27/03/15 14:04, Ian Campbell wrote:
> On Fri, 2015-03-27 at 00:10 +0000, Iain Paton wrote:
>> clock divisors table was missing an entry for 912MHz. The same table is
>> used for sun7i where the default boot clock is 912MHz, resulting in A20
>> boards being overclocked to 960MHz
>
> Apart from the missing entry, should it not be the case that we pick the
> highest frequency <= than the requested frequency, rather than the next
> available (potentially higher) frequency?
>
> IOW I'd expect things to be underclocked at 768MHz without this change,
> which would mean that clock_set_pll1 is buggy.
Perhaps, however the selection algorithm is so trivial that I have
difficulty beleiving that picking next highest was anything other than
deliberate and the intended outcome.
I'll send a revised version that changes it to next lowest.
Rgds,
Iain
prev parent reply other threads:[~2015-03-28 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 0:10 [U-Boot] [PATCH 1/3] sunxi: sun4i: add missing 912MHz clock divisors Iain Paton
2015-03-27 14:04 ` Ian Campbell
2015-03-28 10:24 ` Iain Paton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55168171.2000200@gmail.com \
--to=ipaton0@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.