From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Sat, 28 Mar 2015 14:13:25 +0000 Subject: Re: [lm-sensors] [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Message-Id: <5516B705.1010800@roeck-us.net> List-Id: References: <1427538255-10860-1-git-send-email-pali.rohar@gmail.com> <1427538255-10860-3-git-send-email-pali.rohar@gmail.com> <1427540660.2334.14.camel@x220> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Steven Honeyman , Paul Bolle Cc: =?UTF-8?B?UGFsaSBSb2jDoXI=?= , Arnd Bergmann , Greg Kroah-Hartman , Jean Delvare , Valdis Kletnieks , Jochen Eisinger , Gabriele Mazzotta , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org T24gMDMvMjgvMjAxNSAwNTo1NCBBTSwgU3RldmVuIEhvbmV5bWFuIHdyb3RlOgo+IE9uIDI4IE1h cmNoIDIwMTUgYXQgMTE6MDQsIFBhdWwgQm9sbGUgPHBlYm9sbGVAdGlzY2FsaS5ubD4gd3JvdGU6 Cj4+IE9uIFNhdCwgMjAxNS0wMy0yOCBhdCAxMToyNCArMDEwMCwgUGFsaSBSb2jDoXIgd3JvdGU6 Cj4+PiAtLS0gYS9kcml2ZXJzL2h3bW9uL0tjb25maWcKPj4+ICsrKyBiL2RyaXZlcnMvaHdtb24v S2NvbmZpZwo+Pj4gQEAgLTE3MDMsNiArMTcwMywxNyBAQCBjb25maWcgU0VOU09SU19VTFRSQTQ1 Cj4+PiAgICAgICAgICBUaGlzIGRyaXZlciBwcm92aWRlcyBzdXBwb3J0IGZvciB0aGUgVWx0cmE0 NSB3b3Jrc3RhdGlvbiBlbnZpcm9ubWVudGFsCj4+PiAgICAgICAgICBzZW5zb3JzLgo+Pj4KPj4+ ICtjb25maWcgU0VOU09SU19ERUxMX1NNTQo+Pj4gKyAgICAgdHJpc3RhdGUgIkRlbGwgbGFwdG9w IFNNTSBCSU9TIGh3bW9uIGRyaXZlciIKPj4+ICsgICAgIGRlcGVuZHMgT04gWDg2Cj4+Cj4+IEhv dyBkaWQgdGhpcyBwYXN0IHlvdXIgdGVzdGluZz8KPj4KPj4+ICsgICAgIC0tLWhlbHAtLS0KPj4+ ICsgICAgICAgVGhpcyBod21vbiBkcml2ZXIgYWRkcyBzdXBwb3J0IGZvciByZXBvcnRpbmcgdGVt cGVyYXR1cmUgb2YgZGlmZmVyZW50Cj4+PiArICAgICAgIHNlbnNvcnMgYW5kIGNvbnRyb2xzIHRo ZSBmYW5zIG9uIERlbGwgbGFwdG9wcyB2aWEgU3lzdGVtIE1hbmFnZW1lbnQKPj4+ICsgICAgICAg TW9kZSBwcm92aWRlZCBieSBEZWxsIEJJT1MuCj4+PiArCj4+PiArICAgICAgIFdoZW4gb3B0aW9u IEk4SyBpcyBhbHNvIGVuYWJsZWQgdGhpcyBkcml2ZXIgcHJvdmlkZXMgbGVnYWN5IC9wcm9jL2k4 awo+Pj4gKyAgICAgICB1c2Vyc3BhY2UgaW50ZXJmYWNlIGZvciBpOGt1dGlscyBwYWNrYWdlLgo+ Pj4gKwo+Cj4gSXQncyB3b3JraW5nIE9LIGZvciBtZSAoYWZ0ZXIgZml4aW5nIHRoZSBtaXN0YWtl IHBvaW50ZWQgb3V0IGFib3ZlKS4KPgo+IFtMYXRpdHVkZSBlNjU0MF0KPiAtLS0tLQo+IGNvcmV0 ZW1wLWlzYS0wMDAwCj4gQWRhcHRlcjogSVNBIGFkYXB0ZXIKPiBQaHlzaWNhbCBpZCAwOiAgKzUz LjDCsEMgIChoaWdoID0gKzg0LjDCsEMsIGNyaXQgPSArMTAwLjDCsEMpCj4gQ29yZSAwOiAgICAg ICAgICs1MS4wwrBDICAoaGlnaCA9ICs4NC4wwrBDLCBjcml0ID0gKzEwMC4wwrBDKQo+IENvcmUg MTogICAgICAgICArNTMuMMKwQyAgKGhpZ2ggPSArODQuMMKwQywgY3JpdCA9ICsxMDAuMMKwQykK Pgo+IGk4ay12aXJ0dWFsLTAKPiBBZGFwdGVyOiBWaXJ0dWFsIGRldmljZQo+IFByb2Nlc3NvciBG YW46IDMxNzEgUlBNCj4gQ1BVOiAgICAgICAgICAgICs1Mi4wwrBDCj4gQW1iaWVudDogICAgICAg ICs0Ni4wwrBDCj4gU09ESU1NOiAgICAgICAgICs0MC4wwrBDCj4gLS0tLS0KPgo+IEFtYmllbnQg YW5kIFNPRElNTSBsb29rIHN3YXBwZWQgLSBidXQgaXQncyBwcm9iYWJseSBqdXN0IGFub3RoZXIg RGVsbAo+IGVycm9yLiBJIHJlYWxseSBuZWVkIHRvIGxvb2sgYXQgZ2V0dGluZyBjb3JlYm9vdCBv biB0aGlzIHRoaW5nLgo+Cj4gT24gMjggTWFyY2ggMjAxNSBhdCAxMDoyNCwgUGFsaSBSb2jDoXIg PHBhbGkucm9oYXJAZ21haWwuY29tPiB3cm90ZToKPiAuLi4KPj4gICBjb25maWcgSThLCj4+IC0g ICAgICAgdHJpc3RhdGUgIkRlbGwgbGFwdG9wIHN1cHBvcnQiCj4+IC0gICAgICAgc2VsZWN0IEhX TU9OCj4+ICsgICAgICAgYm9vbCAiRGVsbCBpOGsgbGVnYWN5IGxhcHRvcCBzdXBwb3J0Igo+PiAr ICAgICAgIHNlbGVjdCBTRU5TT1JTX0RFTExfU01NCj4gLi4uCj4+ICtjb25maWcgU0VOU09SU19E RUxMX1NNTQo+PiArICAgICAgIHRyaXN0YXRlICJEZWxsIGxhcHRvcCBTTU0gQklPUyBod21vbiBk cml2ZXIiCj4KPiBUaGUgb25seSBjaGFuZ2UgSSdkIHN1Z2dlc3QgaXMgbm90IHRvIGNoYW5nZSB0 aGUgdHJpc3RhdGUgdG8gYm9vbCBmb3IKPiBJOEsuIEZvcmNpbmcgdGhhdCB0byBib29sIG1lYW5z IHRoYXQgU0VOU09SU19ERUxMX1NNTSBjYW4ndCBiZQo+IGNvbXBpbGVkIGFzIGEgbW9kdWxlIGlm IHRoZSB1c2VyIHdpc2hlcyB0byBrZWVwIGk4ayBoYW5naW5nIGFyb3VuZAo+ICJqdXN0IGluIGNh c2UiLiBJdCdsbCBwcm9iYWJseSBhbm5veSBkaXN0cm8ga2VybmVsIHBhY2thZ2VycyB0b28uCj4K CkFncmVlZC4gSXQgYWxzbyBzdGlsbCBuZWVkcyB0byBzZWxlY3QgSFdNT04gKFNFTlNPUlNfREVM TF9TTU0gaXMKb25seSB2aXNpYmxlIGlmIEhXTU9OIGlzIHNlbGVjdGVkKS4KCkd1ZW50ZXIKCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsbS1zZW5zb3Jz IG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnCmh0dHA6Ly9saXN0cy5sbS1z ZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNlbnNvcnM From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753035AbbC1OOl (ORCPT ); Sat, 28 Mar 2015 10:14:41 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:51574 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076AbbC1OOi (ORCPT ); Sat, 28 Mar 2015 10:14:38 -0400 Message-ID: <5516B705.1010800@roeck-us.net> Date: Sat, 28 Mar 2015 07:13:25 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Steven Honeyman , Paul Bolle CC: =?UTF-8?B?UGFsaSBSb2jDoXI=?= , Arnd Bergmann , Greg Kroah-Hartman , Jean Delvare , Valdis Kletnieks , Jochen Eisinger , Gabriele Mazzotta , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org Subject: Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k References: <1427538255-10860-1-git-send-email-pali.rohar@gmail.com> <1427538255-10860-3-git-send-email-pali.rohar@gmail.com> <1427540660.2334.14.camel@x220> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020204.5516B74D.00EC,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 2 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/28/2015 05:54 AM, Steven Honeyman wrote: > On 28 March 2015 at 11:04, Paul Bolle wrote: >> On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: >>> --- a/drivers/hwmon/Kconfig >>> +++ b/drivers/hwmon/Kconfig >>> @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 >>> This driver provides support for the Ultra45 workstation environmental >>> sensors. >>> >>> +config SENSORS_DELL_SMM >>> + tristate "Dell laptop SMM BIOS hwmon driver" >>> + depends ON X86 >> >> How did this past your testing? >> >>> + ---help--- >>> + This hwmon driver adds support for reporting temperature of different >>> + sensors and controls the fans on Dell laptops via System Management >>> + Mode provided by Dell BIOS. >>> + >>> + When option I8K is also enabled this driver provides legacy /proc/i8k >>> + userspace interface for i8kutils package. >>> + > > It's working OK for me (after fixing the mistake pointed out above). > > [Latitude e6540] > ----- > coretemp-isa-0000 > Adapter: ISA adapter > Physical id 0: +53.0°C (high = +84.0°C, crit = +100.0°C) > Core 0: +51.0°C (high = +84.0°C, crit = +100.0°C) > Core 1: +53.0°C (high = +84.0°C, crit = +100.0°C) > > i8k-virtual-0 > Adapter: Virtual device > Processor Fan: 3171 RPM > CPU: +52.0°C > Ambient: +46.0°C > SODIMM: +40.0°C > ----- > > Ambient and SODIMM look swapped - but it's probably just another Dell > error. I really need to look at getting coreboot on this thing. > > On 28 March 2015 at 10:24, Pali Rohár wrote: > ... >> config I8K >> - tristate "Dell laptop support" >> - select HWMON >> + bool "Dell i8k legacy laptop support" >> + select SENSORS_DELL_SMM > ... >> +config SENSORS_DELL_SMM >> + tristate "Dell laptop SMM BIOS hwmon driver" > > The only change I'd suggest is not to change the tristate to bool for > I8K. Forcing that to bool means that SENSORS_DELL_SMM can't be > compiled as a module if the user wishes to keep i8k hanging around > "just in case". It'll probably annoy distro kernel packagers too. > Agreed. It also still needs to select HWMON (SENSORS_DELL_SMM is only visible if HWMON is selected). Guenter