From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Grant Likely <grant.likely@linaro.org>,
robh+dt@kernel.org, devicetree@vger.kernel.org,
f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] of_net: factor out repetitive code from of_get_mac_address()
Date: Sat, 28 Mar 2015 20:17:57 +0300 [thread overview]
Message-ID: <5516E245.30605@cogentembedded.com> (raw)
In-Reply-To: <20150328133445.52B51C40AAB@trevor.secretlab.ca>
Hello.
On 03/28/2015 04:34 PM, Grant Likely wrote:
>> of_get_mac_address() basically does the same thing thrice, every time with a
>> different property name, so it makes sense to factor out the repetitive code
>> into separate function. While at it, we can start using ETH_ALEN instead of the
>> bare number and drop unnecessary parens around the property length check.
>> The resulting ARM object file is 100 bytes less in size than before the patch.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> The patch is against Grant Likely's 'linux.git' repo's 'devicetree/next' branch.
> Thanks for looking at this, I've merged it.
> Since you're already playing with this, could you also write a unittest
> of of_get_mac_addr()? (drivers/of/unittest.c & drivers/of/unittest-data)
Unfortunately, I'm constantly low on time. Even this patch was done on
weekend.
> g.
WBR, Sergei
prev parent reply other threads:[~2015-03-28 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 19:25 [PATCH] of_net: factor out repetitive code from of_get_mac_address() Sergei Shtylyov
2015-03-18 19:29 ` David Miller
2015-03-28 13:27 ` Grant Likely
[not found] ` <1776166.J84mUn2Yu8-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2015-03-18 19:46 ` Florian Fainelli
2015-03-28 13:34 ` Grant Likely
2015-03-28 17:17 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5516E245.30605@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=grant.likely@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.