From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer
Date: Sat, 28 Mar 2015 23:50:08 +0200 [thread overview]
Message-ID: <55172210.4070900@ti.com> (raw)
In-Reply-To: <551626A5.3080509@wwwdotorg.org>
Thanks,
On 03/28/2015 05:57 AM, Stephen Warren wrote:
> On 03/27/2015 05:35 AM, Peter Ujfalusi wrote:
>> The vd->node is removed from the lists when the transfer started so the
>> vchan_get_all_descriptors() will not find it. This results memory leak.
>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> (I'm just assuming the explanation makes sense and is correct; more of a
> not-a-NAK so it doesn't look like a lack of response!)
I can not debug the bcm2835-dma driver, but the exact same pattern existed in
edma and omap-dma driver and they both leaked the edesc in a same predictable
fashion. I just checked the virt-dma users and sent the fixes for the ones
which had the same flow of events.
--
P?ter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: <vinod.koul@intel.com>, <linux@arm.linux.org.uk>,
<dan.j.williams@intel.com>, <dmaengine@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Lee Jones <lee@kernel.org>
Subject: Re: [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer
Date: Sat, 28 Mar 2015 23:50:08 +0200 [thread overview]
Message-ID: <55172210.4070900@ti.com> (raw)
In-Reply-To: <551626A5.3080509@wwwdotorg.org>
Thanks,
On 03/28/2015 05:57 AM, Stephen Warren wrote:
> On 03/27/2015 05:35 AM, Peter Ujfalusi wrote:
>> The vd->node is removed from the lists when the transfer started so the
>> vchan_get_all_descriptors() will not find it. This results memory leak.
>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> (I'm just assuming the explanation makes sense and is correct; more of a
> not-a-NAK so it doesn't look like a lack of response!)
I can not debug the bcm2835-dma driver, but the exact same pattern existed in
edma and omap-dma driver and they both leaked the edesc in a same predictable
fashion. I just checked the virt-dma users and sent the fixes for the ones
which had the same flow of events.
--
Péter
next prev parent reply other threads:[~2015-03-28 21:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 11:35 [PATCH 0/5] dmaengine: Fix memory leak amongs virt-dma users Peter Ujfalusi
2015-03-27 11:35 ` Peter Ujfalusi
2015-03-27 11:35 ` [PATCH 1/5] dmaengine: edma: fix memory leak when terminating running transfers Peter Ujfalusi
2015-03-27 11:35 ` Peter Ujfalusi
2015-03-27 11:35 ` Peter Ujfalusi
2015-03-30 17:48 ` Vinod Koul
2015-03-30 17:48 ` Vinod Koul
2015-03-27 11:35 ` [PATCH 2/5] dmaengine: omap-dma: Fix memory leak when terminating running transfer Peter Ujfalusi
2015-03-27 11:35 ` Peter Ujfalusi
2015-03-27 11:35 ` Peter Ujfalusi
2015-03-30 17:48 ` Vinod Koul
2015-03-30 17:48 ` Vinod Koul
2015-03-27 11:35 ` [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a " Peter Ujfalusi
2015-03-27 11:35 ` Peter Ujfalusi
2015-03-28 3:57 ` Stephen Warren
2015-03-28 3:57 ` Stephen Warren
2015-03-28 21:50 ` Peter Ujfalusi [this message]
2015-03-28 21:50 ` Peter Ujfalusi
2015-03-30 17:48 ` Vinod Koul
2015-03-30 17:48 ` Vinod Koul
2015-03-27 11:35 ` [PATCH 4/5] dmaengine: hsu: " Peter Ujfalusi
2015-03-27 11:35 ` Peter Ujfalusi
2015-03-27 12:01 ` Andy Shevchenko
2015-03-27 12:01 ` Andy Shevchenko
2015-03-30 17:37 ` Vinod Koul
2015-03-30 17:37 ` Vinod Koul
2015-04-28 11:17 ` 'Greg Kroah-Hartman'
2015-04-28 11:17 ` 'Greg Kroah-Hartman'
2015-05-04 11:04 ` Vinod Koul
2015-05-04 11:04 ` Vinod Koul
2015-05-07 16:26 ` Andy Shevchenko
2015-05-07 16:26 ` Andy Shevchenko
2015-03-27 11:35 ` [PATCH 5/5] dmaengine: moxart-dma: " Peter Ujfalusi
2015-03-27 11:35 ` Peter Ujfalusi
2015-03-30 17:49 ` Vinod Koul
2015-03-30 17:49 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55172210.4070900@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.