diff for duplicates of <55172939.4070100@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index af26b51..a54c1c1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,61 +1,104 @@ -T24gMDMvMjgvMjAxNSAwMzowMCBQTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gT24gU2F0dXJkYXkg -MjggTWFyY2ggMjAxNSAxMzo1NDo1MSBTdGV2ZW4gSG9uZXltYW4gd3JvdGU6Cj4+IE9uIDI4IE1h -cmNoIDIwMTUgYXQgMTE6MDQsIFBhdWwgQm9sbGUgPHBlYm9sbGVAdGlzY2FsaS5ubD4KPiB3cm90 -ZToKPj4+IE9uIFNhdCwgMjAxNS0wMy0yOCBhdCAxMToyNCArMDEwMCwgUGFsaSBSb2jDoXIgd3Jv -dGU6Cj4+Pj4gLS0tIGEvZHJpdmVycy9od21vbi9LY29uZmlnCj4+Pj4gKysrIGIvZHJpdmVycy9o -d21vbi9LY29uZmlnCj4+Pj4gQEAgLTE3MDMsNiArMTcwMywxNyBAQCBjb25maWcgU0VOU09SU19V -TFRSQTQ1Cj4+Pj4KPj4+PiAgICAgICAgICBUaGlzIGRyaXZlciBwcm92aWRlcyBzdXBwb3J0IGZv -ciB0aGUgVWx0cmE0NQo+Pj4+ICAgICAgICAgIHdvcmtzdGF0aW9uIGVudmlyb25tZW50YWwgc2Vu -c29ycy4KPj4+Pgo+Pj4+ICtjb25maWcgU0VOU09SU19ERUxMX1NNTQo+Pj4+ICsgICAgIHRyaXN0 -YXRlICJEZWxsIGxhcHRvcCBTTU0gQklPUyBod21vbiBkcml2ZXIiCj4+Pj4gKyAgICAgZGVwZW5k -cyBPTiBYODYKPj4+Cj4+PiBIb3cgZGlkIHRoaXMgcGFzdCB5b3VyIHRlc3Rpbmc/Cj4+Pgo+Pj4+ -ICsgICAgIC0tLWhlbHAtLS0KPj4+PiArICAgICAgIFRoaXMgaHdtb24gZHJpdmVyIGFkZHMgc3Vw -cG9ydCBmb3IgcmVwb3J0aW5nCj4+Pj4gdGVtcGVyYXR1cmUgb2YgZGlmZmVyZW50ICsgICAgICAg -c2Vuc29ycyBhbmQgY29udHJvbHMgdGhlCj4+Pj4gZmFucyBvbiBEZWxsIGxhcHRvcHMgdmlhIFN5 -c3RlbSBNYW5hZ2VtZW50ICsgICAgICAgTW9kZQo+Pj4+IHByb3ZpZGVkIGJ5IERlbGwgQklPUy4K -Pj4+PiArCj4+Pj4gKyAgICAgICBXaGVuIG9wdGlvbiBJOEsgaXMgYWxzbyBlbmFibGVkIHRoaXMg -ZHJpdmVyCj4+Pj4gcHJvdmlkZXMgbGVnYWN5IC9wcm9jL2k4ayArICAgICAgIHVzZXJzcGFjZSBp -bnRlcmZhY2UgZm9yCj4+Pj4gaThrdXRpbHMgcGFja2FnZS4KPj4+PiArCj4+Cj4+IEl0J3Mgd29y -a2luZyBPSyBmb3IgbWUgKGFmdGVyIGZpeGluZyB0aGUgbWlzdGFrZSBwb2ludGVkIG91dAo+PiBh -Ym92ZSkuCj4+Cj4+IFtMYXRpdHVkZSBlNjU0MF0KPj4gLS0tLS0KPj4gY29yZXRlbXAtaXNhLTAw -MDAKPj4gQWRhcHRlcjogSVNBIGFkYXB0ZXIKPj4gUGh5c2ljYWwgaWQgMDogICs1My4wwrBDICAo -aGlnaCA9ICs4NC4wwrBDLCBjcml0ID0gKzEwMC4wwrBDKQo+PiBDb3JlIDA6ICAgICAgICAgKzUx -LjDCsEMgIChoaWdoID0gKzg0LjDCsEMsIGNyaXQgPSArMTAwLjDCsEMpCj4+IENvcmUgMTogICAg -ICAgICArNTMuMMKwQyAgKGhpZ2ggPSArODQuMMKwQywgY3JpdCA9ICsxMDAuMMKwQykKPj4KPj4g -aThrLXZpcnR1YWwtMAo+PiBBZGFwdGVyOiBWaXJ0dWFsIGRldmljZQo+PiBQcm9jZXNzb3IgRmFu -OiAzMTcxIFJQTQo+PiBDUFU6ICAgICAgICAgICAgKzUyLjDCsEMKPj4gQW1iaWVudDogICAgICAg -ICs0Ni4wwrBDCj4+IFNPRElNTTogICAgICAgICArNDAuMMKwQwo+PiAtLS0tLQo+Pgo+PiBBbWJp -ZW50IGFuZCBTT0RJTU0gbG9vayBzd2FwcGVkIC0gYnV0IGl0J3MgcHJvYmFibHkganVzdAo+PiBh -bm90aGVyIERlbGwgZXJyb3IuIEkgcmVhbGx5IG5lZWQgdG8gbG9vayBhdCBnZXR0aW5nIGNvcmVi -b290Cj4+IG9uIHRoaXMgdGhpbmcuCj4+Cj4KPiBCb3RoIHBhdGNoZXMgZG8gbm90IGNoYW5nZSBh -bnkgY29kZS4gU28gdGhlcmUgc2hvdWxkIG5vdCBiZSBhbnkKPiB0eXBlIHN3YXBwZWQgd2l0aCBv -ciB3aXRob3V0IG15IHBhdGNoLgo+Cj4gQ3B1IHR5cGUgaXMgcmVxdWVzdGVkIHZpYSBTTU0gaW4g -c2FtZSB3YXkgYXMgaXQgaXMgZG9pbmcgb2xkIERPUwo+IGV4ZWN1dGFibGUuIFNvIHRoZXJlIGNh -biBiZSBtYXliZSBwcm9ibGVtIGluIERFTEwgU01NIGhhbmRsZXIgdG9vCj4gb3IgbWF5YmUganVz -dCBJIGRpZCBub3QgdW5kZXJzdGFuZCBjb3JyZWN0bHkgYXNzZW1ibGVyIGR1bXAgb2YKPiBET1Mg -ZXhlY3V0YWJsZS4uLgo+Cj4+IE9uIDI4IE1hcmNoIDIwMTUgYXQgMTA6MjQsIFBhbGkgUm9ow6Fy -IDxwYWxpLnJvaGFyQGdtYWlsLmNvbT4KPj4gd3JvdGU6IC4uLgo+Pgo+Pj4gICBjb25maWcgSThL -Cj4+Pgo+Pj4gLSAgICAgICB0cmlzdGF0ZSAiRGVsbCBsYXB0b3Agc3VwcG9ydCIKPj4+IC0gICAg -ICAgc2VsZWN0IEhXTU9OCj4+PiArICAgICAgIGJvb2wgIkRlbGwgaThrIGxlZ2FjeSBsYXB0b3Ag -c3VwcG9ydCIKPj4+ICsgICAgICAgc2VsZWN0IFNFTlNPUlNfREVMTF9TTU0KPj4KPj4gLi4uCj4+ -Cj4+PiArY29uZmlnIFNFTlNPUlNfREVMTF9TTU0KPj4+ICsgICAgICAgdHJpc3RhdGUgIkRlbGwg -bGFwdG9wIFNNTSBCSU9TIGh3bW9uIGRyaXZlciIKPj4KPj4gVGhlIG9ubHkgY2hhbmdlIEknZCBz -dWdnZXN0IGlzIG5vdCB0byBjaGFuZ2UgdGhlIHRyaXN0YXRlIHRvCj4+IGJvb2wgZm9yIEk4Sy4g -Rm9yY2luZyB0aGF0IHRvIGJvb2wgbWVhbnMgdGhhdAo+PiBTRU5TT1JTX0RFTExfU01NIGNhbid0 -IGJlIGNvbXBpbGVkIGFzIGEgbW9kdWxlIGlmIHRoZSB1c2VyCj4+IHdpc2hlcyB0byBrZWVwIGk4 -ayBoYW5naW5nIGFyb3VuZCAianVzdCBpbiBjYXNlIi4gSXQnbGwKPj4gcHJvYmFibHkgYW5ub3kg -ZGlzdHJvIGtlcm5lbCBwYWNrYWdlcnMgdG9vLgo+Pgo+Pgo+PiBUaGFua3MsCj4+IFN0ZXZlbgo+ -Cj4gTXkgaWRlYSB3YXM6Cj4KPiBTRU5TT1JTX0RFTExfU01NIGVuYWJsZS9kaXNhYmxlIGNvbXBp -bGF0aW9uIG9mIGtlcm5lbCBkcml2ZXIKPiAoZXRoZXIgc3RhdGljYWxseSBsaW5rIGludG8ga2Vy -bmVsIGltYWdlIG9yIGFzIGV4dGVybmFsIG1vZHVsZSkKPgo+IENPTkZJR19JOEsganVzdCBlbmFi -bGUgL3Byb2MvaThrIGNvZGUgaW4gU0VOU09SU19ERUxMX1NNTSAtLSBubwo+IGFkZGl0aW9uYWwg -ZHJpdmVyLCBqdXN0IGJvb2xlYW4gc3dpdGNoIHdoaWNoIGhhcyBlZmZlY3Qgb25seSBpZmYKPiBT -RU5TT1JTX0RFTExfU01NIGlzIFkgb3IgTQo+CgpNYXliZSB0aGF0IGlzIHRoZSBwbGFuLCBidXQg -aXQgaXMgbm90IHdoYXQgaXMgaGFwcGVuaW5nLgpJOEsgc2VsZWN0cyBTRU5TT1JTX0RFTExfU01N -LCBzbyBhIGJvb2xlYW4gSThLIGZvcmNlcyBTRU5TT1JTX0RFTExfU01NCnRvIGJlIGJ1aWx0IGlu -dG8gdGhlIGtlcm5lbC4KCldoYXQgeW91IHN1Z2dlc3Qgd291bGQgd29yayBpZiBJOEsgd291bGQg -ZGVwZW5kIG9uIFNFTlNPUlNfREVMTF9TTU0sCmJ1dCB0aGVuIHRoZSBzeW1ib2xzIHdvdWxkIG5v -dCBiZSBiYWNrd2FyZC1jb21wYXRpYmxlLgoKR3VlbnRlcgoKCl9fX19fX19fX19fX19fX19fX19f -X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNl -bnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4v -bGlzdGluZm8vbG0tc2Vuc29ycw= +On 03/28/2015 03:00 PM, Pali Rohár wrote: +> On Saturday 28 March 2015 13:54:51 Steven Honeyman wrote: +>> On 28 March 2015 at 11:04, Paul Bolle <pebolle@tiscali.nl> +> wrote: +>>> On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: +>>>> --- a/drivers/hwmon/Kconfig +>>>> +++ b/drivers/hwmon/Kconfig +>>>> @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 +>>>> +>>>> This driver provides support for the Ultra45 +>>>> workstation environmental sensors. +>>>> +>>>> +config SENSORS_DELL_SMM +>>>> + tristate "Dell laptop SMM BIOS hwmon driver" +>>>> + depends ON X86 +>>> +>>> How did this past your testing? +>>> +>>>> + ---help--- +>>>> + This hwmon driver adds support for reporting +>>>> temperature of different + sensors and controls the +>>>> fans on Dell laptops via System Management + Mode +>>>> provided by Dell BIOS. +>>>> + +>>>> + When option I8K is also enabled this driver +>>>> provides legacy /proc/i8k + userspace interface for +>>>> i8kutils package. +>>>> + +>> +>> It's working OK for me (after fixing the mistake pointed out +>> above). +>> +>> [Latitude e6540] +>> ----- +>> coretemp-isa-0000 +>> Adapter: ISA adapter +>> Physical id 0: +53.0°C (high = +84.0°C, crit = +100.0°C) +>> Core 0: +51.0°C (high = +84.0°C, crit = +100.0°C) +>> Core 1: +53.0°C (high = +84.0°C, crit = +100.0°C) +>> +>> i8k-virtual-0 +>> Adapter: Virtual device +>> Processor Fan: 3171 RPM +>> CPU: +52.0°C +>> Ambient: +46.0°C +>> SODIMM: +40.0°C +>> ----- +>> +>> Ambient and SODIMM look swapped - but it's probably just +>> another Dell error. I really need to look at getting coreboot +>> on this thing. +>> +> +> Both patches do not change any code. So there should not be any +> type swapped with or without my patch. +> +> Cpu type is requested via SMM in same way as it is doing old DOS +> executable. So there can be maybe problem in DELL SMM handler too +> or maybe just I did not understand correctly assembler dump of +> DOS executable... +> +>> On 28 March 2015 at 10:24, Pali Rohár <pali.rohar@gmail.com> +>> wrote: ... +>> +>>> config I8K +>>> +>>> - tristate "Dell laptop support" +>>> - select HWMON +>>> + bool "Dell i8k legacy laptop support" +>>> + select SENSORS_DELL_SMM +>> +>> ... +>> +>>> +config SENSORS_DELL_SMM +>>> + tristate "Dell laptop SMM BIOS hwmon driver" +>> +>> The only change I'd suggest is not to change the tristate to +>> bool for I8K. Forcing that to bool means that +>> SENSORS_DELL_SMM can't be compiled as a module if the user +>> wishes to keep i8k hanging around "just in case". It'll +>> probably annoy distro kernel packagers too. +>> +>> +>> Thanks, +>> Steven +> +> My idea was: +> +> SENSORS_DELL_SMM enable/disable compilation of kernel driver +> (ether statically link into kernel image or as external module) +> +> CONFIG_I8K just enable /proc/i8k code in SENSORS_DELL_SMM -- no +> additional driver, just boolean switch which has effect only iff +> SENSORS_DELL_SMM is Y or M +> + +Maybe that is the plan, but it is not what is happening. +I8K selects SENSORS_DELL_SMM, so a boolean I8K forces SENSORS_DELL_SMM +to be built into the kernel. + +What you suggest would work if I8K would depend on SENSORS_DELL_SMM, +but then the symbols would not be backward-compatible. + +Guenter diff --git a/a/content_digest b/N1/content_digest index 8246478..85d4bac 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,8 +3,8 @@ "ref\0CABz95_BkAvPoBAm_tRLH6OhCk_pDfJQ8UuwfhuEYuPNt3P-PGw@mail.gmail.com\0" "ref\0201503282300.48749@pali\0" "From\0Guenter Roeck <linux@roeck-us.net>\0" - "Subject\0Re: [lm-sensors] [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k\0" - "Date\0Sat, 28 Mar 2015 22:20:41 +0000\0" + "Subject\0Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k\0" + "Date\0Sat, 28 Mar 2015 15:20:41 -0700\0" "To\0Pali Roh\303\241r <pali.rohar@gmail.com>" " Steven Honeyman <stevenhoneyman@gmail.com>\0" "Cc\0Paul Bolle <pebolle@tiscali.nl>" @@ -18,66 +18,109 @@ " lm-sensors@lm-sensors.org\0" "\00:1\0" "b\0" - "T24gMDMvMjgvMjAxNSAwMzowMCBQTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gT24gU2F0dXJkYXkg\n" - "MjggTWFyY2ggMjAxNSAxMzo1NDo1MSBTdGV2ZW4gSG9uZXltYW4gd3JvdGU6Cj4+IE9uIDI4IE1h\n" - "cmNoIDIwMTUgYXQgMTE6MDQsIFBhdWwgQm9sbGUgPHBlYm9sbGVAdGlzY2FsaS5ubD4KPiB3cm90\n" - "ZToKPj4+IE9uIFNhdCwgMjAxNS0wMy0yOCBhdCAxMToyNCArMDEwMCwgUGFsaSBSb2jDoXIgd3Jv\n" - "dGU6Cj4+Pj4gLS0tIGEvZHJpdmVycy9od21vbi9LY29uZmlnCj4+Pj4gKysrIGIvZHJpdmVycy9o\n" - "d21vbi9LY29uZmlnCj4+Pj4gQEAgLTE3MDMsNiArMTcwMywxNyBAQCBjb25maWcgU0VOU09SU19V\n" - "TFRSQTQ1Cj4+Pj4KPj4+PiAgICAgICAgICBUaGlzIGRyaXZlciBwcm92aWRlcyBzdXBwb3J0IGZv\n" - "ciB0aGUgVWx0cmE0NQo+Pj4+ICAgICAgICAgIHdvcmtzdGF0aW9uIGVudmlyb25tZW50YWwgc2Vu\n" - "c29ycy4KPj4+Pgo+Pj4+ICtjb25maWcgU0VOU09SU19ERUxMX1NNTQo+Pj4+ICsgICAgIHRyaXN0\n" - "YXRlICJEZWxsIGxhcHRvcCBTTU0gQklPUyBod21vbiBkcml2ZXIiCj4+Pj4gKyAgICAgZGVwZW5k\n" - "cyBPTiBYODYKPj4+Cj4+PiBIb3cgZGlkIHRoaXMgcGFzdCB5b3VyIHRlc3Rpbmc/Cj4+Pgo+Pj4+\n" - "ICsgICAgIC0tLWhlbHAtLS0KPj4+PiArICAgICAgIFRoaXMgaHdtb24gZHJpdmVyIGFkZHMgc3Vw\n" - "cG9ydCBmb3IgcmVwb3J0aW5nCj4+Pj4gdGVtcGVyYXR1cmUgb2YgZGlmZmVyZW50ICsgICAgICAg\n" - "c2Vuc29ycyBhbmQgY29udHJvbHMgdGhlCj4+Pj4gZmFucyBvbiBEZWxsIGxhcHRvcHMgdmlhIFN5\n" - "c3RlbSBNYW5hZ2VtZW50ICsgICAgICAgTW9kZQo+Pj4+IHByb3ZpZGVkIGJ5IERlbGwgQklPUy4K\n" - "Pj4+PiArCj4+Pj4gKyAgICAgICBXaGVuIG9wdGlvbiBJOEsgaXMgYWxzbyBlbmFibGVkIHRoaXMg\n" - "ZHJpdmVyCj4+Pj4gcHJvdmlkZXMgbGVnYWN5IC9wcm9jL2k4ayArICAgICAgIHVzZXJzcGFjZSBp\n" - "bnRlcmZhY2UgZm9yCj4+Pj4gaThrdXRpbHMgcGFja2FnZS4KPj4+PiArCj4+Cj4+IEl0J3Mgd29y\n" - "a2luZyBPSyBmb3IgbWUgKGFmdGVyIGZpeGluZyB0aGUgbWlzdGFrZSBwb2ludGVkIG91dAo+PiBh\n" - "Ym92ZSkuCj4+Cj4+IFtMYXRpdHVkZSBlNjU0MF0KPj4gLS0tLS0KPj4gY29yZXRlbXAtaXNhLTAw\n" - "MDAKPj4gQWRhcHRlcjogSVNBIGFkYXB0ZXIKPj4gUGh5c2ljYWwgaWQgMDogICs1My4wwrBDICAo\n" - "aGlnaCA9ICs4NC4wwrBDLCBjcml0ID0gKzEwMC4wwrBDKQo+PiBDb3JlIDA6ICAgICAgICAgKzUx\n" - "LjDCsEMgIChoaWdoID0gKzg0LjDCsEMsIGNyaXQgPSArMTAwLjDCsEMpCj4+IENvcmUgMTogICAg\n" - "ICAgICArNTMuMMKwQyAgKGhpZ2ggPSArODQuMMKwQywgY3JpdCA9ICsxMDAuMMKwQykKPj4KPj4g\n" - "aThrLXZpcnR1YWwtMAo+PiBBZGFwdGVyOiBWaXJ0dWFsIGRldmljZQo+PiBQcm9jZXNzb3IgRmFu\n" - "OiAzMTcxIFJQTQo+PiBDUFU6ICAgICAgICAgICAgKzUyLjDCsEMKPj4gQW1iaWVudDogICAgICAg\n" - "ICs0Ni4wwrBDCj4+IFNPRElNTTogICAgICAgICArNDAuMMKwQwo+PiAtLS0tLQo+Pgo+PiBBbWJp\n" - "ZW50IGFuZCBTT0RJTU0gbG9vayBzd2FwcGVkIC0gYnV0IGl0J3MgcHJvYmFibHkganVzdAo+PiBh\n" - "bm90aGVyIERlbGwgZXJyb3IuIEkgcmVhbGx5IG5lZWQgdG8gbG9vayBhdCBnZXR0aW5nIGNvcmVi\n" - "b290Cj4+IG9uIHRoaXMgdGhpbmcuCj4+Cj4KPiBCb3RoIHBhdGNoZXMgZG8gbm90IGNoYW5nZSBh\n" - "bnkgY29kZS4gU28gdGhlcmUgc2hvdWxkIG5vdCBiZSBhbnkKPiB0eXBlIHN3YXBwZWQgd2l0aCBv\n" - "ciB3aXRob3V0IG15IHBhdGNoLgo+Cj4gQ3B1IHR5cGUgaXMgcmVxdWVzdGVkIHZpYSBTTU0gaW4g\n" - "c2FtZSB3YXkgYXMgaXQgaXMgZG9pbmcgb2xkIERPUwo+IGV4ZWN1dGFibGUuIFNvIHRoZXJlIGNh\n" - "biBiZSBtYXliZSBwcm9ibGVtIGluIERFTEwgU01NIGhhbmRsZXIgdG9vCj4gb3IgbWF5YmUganVz\n" - "dCBJIGRpZCBub3QgdW5kZXJzdGFuZCBjb3JyZWN0bHkgYXNzZW1ibGVyIGR1bXAgb2YKPiBET1Mg\n" - "ZXhlY3V0YWJsZS4uLgo+Cj4+IE9uIDI4IE1hcmNoIDIwMTUgYXQgMTA6MjQsIFBhbGkgUm9ow6Fy\n" - "IDxwYWxpLnJvaGFyQGdtYWlsLmNvbT4KPj4gd3JvdGU6IC4uLgo+Pgo+Pj4gICBjb25maWcgSThL\n" - "Cj4+Pgo+Pj4gLSAgICAgICB0cmlzdGF0ZSAiRGVsbCBsYXB0b3Agc3VwcG9ydCIKPj4+IC0gICAg\n" - "ICAgc2VsZWN0IEhXTU9OCj4+PiArICAgICAgIGJvb2wgIkRlbGwgaThrIGxlZ2FjeSBsYXB0b3Ag\n" - "c3VwcG9ydCIKPj4+ICsgICAgICAgc2VsZWN0IFNFTlNPUlNfREVMTF9TTU0KPj4KPj4gLi4uCj4+\n" - "Cj4+PiArY29uZmlnIFNFTlNPUlNfREVMTF9TTU0KPj4+ICsgICAgICAgdHJpc3RhdGUgIkRlbGwg\n" - "bGFwdG9wIFNNTSBCSU9TIGh3bW9uIGRyaXZlciIKPj4KPj4gVGhlIG9ubHkgY2hhbmdlIEknZCBz\n" - "dWdnZXN0IGlzIG5vdCB0byBjaGFuZ2UgdGhlIHRyaXN0YXRlIHRvCj4+IGJvb2wgZm9yIEk4Sy4g\n" - "Rm9yY2luZyB0aGF0IHRvIGJvb2wgbWVhbnMgdGhhdAo+PiBTRU5TT1JTX0RFTExfU01NIGNhbid0\n" - "IGJlIGNvbXBpbGVkIGFzIGEgbW9kdWxlIGlmIHRoZSB1c2VyCj4+IHdpc2hlcyB0byBrZWVwIGk4\n" - "ayBoYW5naW5nIGFyb3VuZCAianVzdCBpbiBjYXNlIi4gSXQnbGwKPj4gcHJvYmFibHkgYW5ub3kg\n" - "ZGlzdHJvIGtlcm5lbCBwYWNrYWdlcnMgdG9vLgo+Pgo+Pgo+PiBUaGFua3MsCj4+IFN0ZXZlbgo+\n" - "Cj4gTXkgaWRlYSB3YXM6Cj4KPiBTRU5TT1JTX0RFTExfU01NIGVuYWJsZS9kaXNhYmxlIGNvbXBp\n" - "bGF0aW9uIG9mIGtlcm5lbCBkcml2ZXIKPiAoZXRoZXIgc3RhdGljYWxseSBsaW5rIGludG8ga2Vy\n" - "bmVsIGltYWdlIG9yIGFzIGV4dGVybmFsIG1vZHVsZSkKPgo+IENPTkZJR19JOEsganVzdCBlbmFi\n" - "bGUgL3Byb2MvaThrIGNvZGUgaW4gU0VOU09SU19ERUxMX1NNTSAtLSBubwo+IGFkZGl0aW9uYWwg\n" - "ZHJpdmVyLCBqdXN0IGJvb2xlYW4gc3dpdGNoIHdoaWNoIGhhcyBlZmZlY3Qgb25seSBpZmYKPiBT\n" - "RU5TT1JTX0RFTExfU01NIGlzIFkgb3IgTQo+CgpNYXliZSB0aGF0IGlzIHRoZSBwbGFuLCBidXQg\n" - "aXQgaXMgbm90IHdoYXQgaXMgaGFwcGVuaW5nLgpJOEsgc2VsZWN0cyBTRU5TT1JTX0RFTExfU01N\n" - "LCBzbyBhIGJvb2xlYW4gSThLIGZvcmNlcyBTRU5TT1JTX0RFTExfU01NCnRvIGJlIGJ1aWx0IGlu\n" - "dG8gdGhlIGtlcm5lbC4KCldoYXQgeW91IHN1Z2dlc3Qgd291bGQgd29yayBpZiBJOEsgd291bGQg\n" - "ZGVwZW5kIG9uIFNFTlNPUlNfREVMTF9TTU0sCmJ1dCB0aGVuIHRoZSBzeW1ib2xzIHdvdWxkIG5v\n" - "dCBiZSBiYWNrd2FyZC1jb21wYXRpYmxlLgoKR3VlbnRlcgoKCl9fX19fX19fX19fX19fX19fX19f\n" - "X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNl\n" - "bnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4v\n" - bGlzdGluZm8vbG0tc2Vuc29ycw= + "On 03/28/2015 03:00 PM, Pali Roh\303\241r wrote:\n" + "> On Saturday 28 March 2015 13:54:51 Steven Honeyman wrote:\n" + ">> On 28 March 2015 at 11:04, Paul Bolle <pebolle@tiscali.nl>\n" + "> wrote:\n" + ">>> On Sat, 2015-03-28 at 11:24 +0100, Pali Roh\303\241r wrote:\n" + ">>>> --- a/drivers/hwmon/Kconfig\n" + ">>>> +++ b/drivers/hwmon/Kconfig\n" + ">>>> @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45\n" + ">>>>\n" + ">>>> This driver provides support for the Ultra45\n" + ">>>> workstation environmental sensors.\n" + ">>>>\n" + ">>>> +config SENSORS_DELL_SMM\n" + ">>>> + tristate \"Dell laptop SMM BIOS hwmon driver\"\n" + ">>>> + depends ON X86\n" + ">>>\n" + ">>> How did this past your testing?\n" + ">>>\n" + ">>>> + ---help---\n" + ">>>> + This hwmon driver adds support for reporting\n" + ">>>> temperature of different + sensors and controls the\n" + ">>>> fans on Dell laptops via System Management + Mode\n" + ">>>> provided by Dell BIOS.\n" + ">>>> +\n" + ">>>> + When option I8K is also enabled this driver\n" + ">>>> provides legacy /proc/i8k + userspace interface for\n" + ">>>> i8kutils package.\n" + ">>>> +\n" + ">>\n" + ">> It's working OK for me (after fixing the mistake pointed out\n" + ">> above).\n" + ">>\n" + ">> [Latitude e6540]\n" + ">> -----\n" + ">> coretemp-isa-0000\n" + ">> Adapter: ISA adapter\n" + ">> Physical id 0: +53.0\302\260C (high = +84.0\302\260C, crit = +100.0\302\260C)\n" + ">> Core 0: +51.0\302\260C (high = +84.0\302\260C, crit = +100.0\302\260C)\n" + ">> Core 1: +53.0\302\260C (high = +84.0\302\260C, crit = +100.0\302\260C)\n" + ">>\n" + ">> i8k-virtual-0\n" + ">> Adapter: Virtual device\n" + ">> Processor Fan: 3171 RPM\n" + ">> CPU: +52.0\302\260C\n" + ">> Ambient: +46.0\302\260C\n" + ">> SODIMM: +40.0\302\260C\n" + ">> -----\n" + ">>\n" + ">> Ambient and SODIMM look swapped - but it's probably just\n" + ">> another Dell error. I really need to look at getting coreboot\n" + ">> on this thing.\n" + ">>\n" + ">\n" + "> Both patches do not change any code. So there should not be any\n" + "> type swapped with or without my patch.\n" + ">\n" + "> Cpu type is requested via SMM in same way as it is doing old DOS\n" + "> executable. So there can be maybe problem in DELL SMM handler too\n" + "> or maybe just I did not understand correctly assembler dump of\n" + "> DOS executable...\n" + ">\n" + ">> On 28 March 2015 at 10:24, Pali Roh\303\241r <pali.rohar@gmail.com>\n" + ">> wrote: ...\n" + ">>\n" + ">>> config I8K\n" + ">>>\n" + ">>> - tristate \"Dell laptop support\"\n" + ">>> - select HWMON\n" + ">>> + bool \"Dell i8k legacy laptop support\"\n" + ">>> + select SENSORS_DELL_SMM\n" + ">>\n" + ">> ...\n" + ">>\n" + ">>> +config SENSORS_DELL_SMM\n" + ">>> + tristate \"Dell laptop SMM BIOS hwmon driver\"\n" + ">>\n" + ">> The only change I'd suggest is not to change the tristate to\n" + ">> bool for I8K. Forcing that to bool means that\n" + ">> SENSORS_DELL_SMM can't be compiled as a module if the user\n" + ">> wishes to keep i8k hanging around \"just in case\". It'll\n" + ">> probably annoy distro kernel packagers too.\n" + ">>\n" + ">>\n" + ">> Thanks,\n" + ">> Steven\n" + ">\n" + "> My idea was:\n" + ">\n" + "> SENSORS_DELL_SMM enable/disable compilation of kernel driver\n" + "> (ether statically link into kernel image or as external module)\n" + ">\n" + "> CONFIG_I8K just enable /proc/i8k code in SENSORS_DELL_SMM -- no\n" + "> additional driver, just boolean switch which has effect only iff\n" + "> SENSORS_DELL_SMM is Y or M\n" + ">\n" + "\n" + "Maybe that is the plan, but it is not what is happening.\n" + "I8K selects SENSORS_DELL_SMM, so a boolean I8K forces SENSORS_DELL_SMM\n" + "to be built into the kernel.\n" + "\n" + "What you suggest would work if I8K would depend on SENSORS_DELL_SMM,\n" + "but then the symbols would not be backward-compatible.\n" + "\n" + Guenter -da87b52e1407222923bb0fd68323e688913f1f5d0900e376f5e0084f0811f61b +d3911eb8a8644ea11dd28a71d64745a4443971a91c65c9d12b497ba2023bfe4c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.