From mboxrd@z Thu Jan 1 00:00:00 1970 From: sbranden@broadcom.com (Scott Branden) Date: Sun, 29 Mar 2015 14:55:55 -0700 Subject: [PATCH] dmaengine: pl330: fix the race condition in pl330 driver. In-Reply-To: <1427414105-3480-1-git-send-email-sbranden@broadcom.com> References: <1427414105-3480-1-git-send-email-sbranden@broadcom.com> Message-ID: <551874EB.1040405@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Adding original author Jaswinder Singh (3 email addresses) to email list. On 15-03-26 04:55 PM, Scott Branden wrote: > From: ismail > > Update the thread running index before issuing the > GO command to the DMAC. > > Tested-by: Mohamed Ismail Abdul Packir Mohamed > Reviewed-by: Ray Jui > Reviewed-by: Arun Parameswaran > Reviewed-by: Scott Branden > Signed-off-by: Scott Branden > Signed-off-by: Mohamed Ismail Abdul Packir Mohamed > --- > drivers/dma/pl330.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index 0e1f567..631642d 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -1072,11 +1072,11 @@ static bool _trigger(struct pl330_thread *thrd) > /* Set to generate interrupts for SEV */ > writel(readl(regs + INTEN) | (1 << thrd->ev), regs + INTEN); > > + thrd->req_running = idx; > + > /* Only manager can execute GO */ > _execute_DBGINSN(thrd, insn, true); > > - thrd->req_running = idx; > - > return true; > } > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbbC2V4L (ORCPT ); Sun, 29 Mar 2015 17:56:11 -0400 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:1810 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752655AbbC2V4I (ORCPT ); Sun, 29 Mar 2015 17:56:08 -0400 X-IronPort-AV: E=Sophos;i="5.11,490,1422950400"; d="scan'208";a="60544708" Message-ID: <551874EB.1040405@broadcom.com> Date: Sun, 29 Mar 2015 14:55:55 -0700 From: Scott Branden User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Dan Williams , Vinod Koul , Jaswinder Singh , Jassi Brar , Jassi Brar CC: , Dmitry Torokhov , Anatol Pomazao , , , ismail Subject: Re: [PATCH] dmaengine: pl330: fix the race condition in pl330 driver. References: <1427414105-3480-1-git-send-email-sbranden@broadcom.com> In-Reply-To: <1427414105-3480-1-git-send-email-sbranden@broadcom.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding original author Jaswinder Singh (3 email addresses) to email list. On 15-03-26 04:55 PM, Scott Branden wrote: > From: ismail > > Update the thread running index before issuing the > GO command to the DMAC. > > Tested-by: Mohamed Ismail Abdul Packir Mohamed > Reviewed-by: Ray Jui > Reviewed-by: Arun Parameswaran > Reviewed-by: Scott Branden > Signed-off-by: Scott Branden > Signed-off-by: Mohamed Ismail Abdul Packir Mohamed > --- > drivers/dma/pl330.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index 0e1f567..631642d 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -1072,11 +1072,11 @@ static bool _trigger(struct pl330_thread *thrd) > /* Set to generate interrupts for SEV */ > writel(readl(regs + INTEN) | (1 << thrd->ev), regs + INTEN); > > + thrd->req_running = idx; > + > /* Only manager can execute GO */ > _execute_DBGINSN(thrd, insn, true); > > - thrd->req_running = idx; > - > return true; > } > >