From: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>
To: Ulf Samuelsson <ulf.samuelsson@ericsson.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, hideaki.yoshifuji@miraclelinux.com,
Yanjun.Zhu@windriver.com
Subject: Re: [PATCH net-next 1/2] net: neighbour: Add mcast_resolicit to configure the number of multicast resolicitations in PROBE state.
Date: Mon, 30 Mar 2015 08:49:44 +0900 [thread overview]
Message-ID: <55188F98.7020803@miraclelinux.com> (raw)
In-Reply-To: <551525F2.3040107@ericsson.com>
Hi,
Ulf Samuelsson wrote:
> Should not this patch add modifications to "kernel/sysctl_binary.c" and
> "include/linux/sysctl.h" as well?
We do not add binary sysctls any more.
> mcast_probes and ucast_probes are initialized in arp.c and ndisc.c.
> Should we not initialize also mcast_reprobes, even if it is zero?
We could, but unneccessary.
> There are some statistics printout in net/core/neighbour.c.
> They handle mcast_solicit and ucast_solicit.
>
> Are they unneccessary for mcast_resolicit?
Not neccessary.
Hint: What are those for? Where/How do we increment those counters?
--
Hideaki Yoshifuji <hideaki.yoshifuji@miraclelinux.com>
Technical Division, MIRACLE LINUX CORPORATION
prev parent reply other threads:[~2015-03-29 23:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 13:41 [PATCH net-next 1/2] net: neighbour: Add mcast_resolicit to configure the number of multicast resolicitations in PROBE state YOSHIFUJI Hideaki
2015-03-19 14:46 ` Ulf Samuelsson
2015-03-19 18:30 ` David Miller
2015-03-21 1:47 ` David Miller
2015-03-23 2:28 ` yzhu1
2015-03-30 0:04 ` YOSHIFUJI Hideaki
2015-03-27 9:42 ` Ulf Samuelsson
2015-03-29 23:49 ` YOSHIFUJI Hideaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55188F98.7020803@miraclelinux.com \
--to=hideaki.yoshifuji@miraclelinux.com \
--cc=Yanjun.Zhu@windriver.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ulf.samuelsson@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.