From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YcQH5-0001iQ-Ga for kexec@lists.infradead.org; Mon, 30 Mar 2015 03:22:04 +0000 Received: by padcy3 with SMTP id cy3so153778429pad.3 for ; Sun, 29 Mar 2015 20:21:40 -0700 (PDT) Message-ID: <5518C13B.6070201@linaro.org> Date: Mon, 30 Mar 2015 12:21:31 +0900 From: AKASHI Takahiro MIME-Version: 1.0 Subject: Re: [PATCH 3/5] arm64: kdump: do not go into EL2 before starting a crash dump kernel References: <1427358533-3754-1-git-send-email-takahiro.akashi@linaro.org> <1427358533-3754-4-git-send-email-takahiro.akashi@linaro.org> <1427408957.6526.1.camel@infradead.org> In-Reply-To: <1427408957.6526.1.camel@infradead.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Geoff Levand Cc: linux-arm-kernel@lists.infradead.org, hbabus@us.ibm.com, linaro-kernel@lists.linaro.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, broonie@kernel.org, david.griego@linaro.org, kexec@lists.infradead.org, vgoyal@redhat.com On 03/27/2015 07:29 AM, Geoff Levand wrote: > On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote: >> @@ -64,7 +65,11 @@ void soft_restart(unsigned long addr) >> setup_mm_for_reboot(); >> >> cpu_soft_restart(virt_to_phys(cpu_reset), >> - is_hyp_mode_available(), addr); >> +#ifdef CONFIG_KEXEC >> + !in_crash_kexec && >> +#endif > > Why not define in_crash_kexec without condition on CONFIG_KEXEC, say > here in process.c and then avoid these preprocessor conditionals. Well, I thought of that, but as its name suggested, the variable should be basically part of kdump code. Moreover, I suspect that some one might reject a whole idea of patch #3. -Takahiro AKASHI >> + is_hyp_mode_available(), >> + addr); >> >> /* Should never get here */ >> BUG(); > > > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: takahiro.akashi@linaro.org (AKASHI Takahiro) Date: Mon, 30 Mar 2015 12:21:31 +0900 Subject: [PATCH 3/5] arm64: kdump: do not go into EL2 before starting a crash dump kernel In-Reply-To: <1427408957.6526.1.camel@infradead.org> References: <1427358533-3754-1-git-send-email-takahiro.akashi@linaro.org> <1427358533-3754-4-git-send-email-takahiro.akashi@linaro.org> <1427408957.6526.1.camel@infradead.org> Message-ID: <5518C13B.6070201@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/27/2015 07:29 AM, Geoff Levand wrote: > On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote: >> @@ -64,7 +65,11 @@ void soft_restart(unsigned long addr) >> setup_mm_for_reboot(); >> >> cpu_soft_restart(virt_to_phys(cpu_reset), >> - is_hyp_mode_available(), addr); >> +#ifdef CONFIG_KEXEC >> + !in_crash_kexec && >> +#endif > > Why not define in_crash_kexec without condition on CONFIG_KEXEC, say > here in process.c and then avoid these preprocessor conditionals. Well, I thought of that, but as its name suggested, the variable should be basically part of kdump code. Moreover, I suspect that some one might reject a whole idea of patch #3. -Takahiro AKASHI >> + is_hyp_mode_available(), >> + addr); >> >> /* Should never get here */ >> BUG(); > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752720AbbC3DVo (ORCPT ); Sun, 29 Mar 2015 23:21:44 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:35562 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752428AbbC3DVl (ORCPT ); Sun, 29 Mar 2015 23:21:41 -0400 Message-ID: <5518C13B.6070201@linaro.org> Date: Mon, 30 Mar 2015 12:21:31 +0900 From: AKASHI Takahiro User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Geoff Levand CC: catalin.marinas@arm.com, will.deacon@arm.com, vgoyal@redhat.com, hbabus@us.ibm.com, broonie@kernel.org, david.griego@linaro.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] arm64: kdump: do not go into EL2 before starting a crash dump kernel References: <1427358533-3754-1-git-send-email-takahiro.akashi@linaro.org> <1427358533-3754-4-git-send-email-takahiro.akashi@linaro.org> <1427408957.6526.1.camel@infradead.org> In-Reply-To: <1427408957.6526.1.camel@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/27/2015 07:29 AM, Geoff Levand wrote: > On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote: >> @@ -64,7 +65,11 @@ void soft_restart(unsigned long addr) >> setup_mm_for_reboot(); >> >> cpu_soft_restart(virt_to_phys(cpu_reset), >> - is_hyp_mode_available(), addr); >> +#ifdef CONFIG_KEXEC >> + !in_crash_kexec && >> +#endif > > Why not define in_crash_kexec without condition on CONFIG_KEXEC, say > here in process.c and then avoid these preprocessor conditionals. Well, I thought of that, but as its name suggested, the variable should be basically part of kdump code. Moreover, I suspect that some one might reject a whole idea of patch #3. -Takahiro AKASHI >> + is_hyp_mode_available(), >> + addr); >> >> /* Should never get here */ >> BUG(); > > >