From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcYAR-0001GE-T5 for qemu-devel@nongnu.org; Mon, 30 Mar 2015 07:47:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcYAO-0002K9-Js for qemu-devel@nongnu.org; Mon, 30 Mar 2015 07:47:43 -0400 Message-ID: <551937D6.6060904@redhat.com> Date: Mon, 30 Mar 2015 13:47:34 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <5516FEDE.3030809@ilande.co.uk> <55191C97.8070308@redhat.com> <5519235C.6090004@ilande.co.uk> <5519256A.1010202@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] ppc vga output breakage since commit c3c1bb99 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: qemu-ppc Mailing List , Mark Cave-Ayland , "qemu-devel@nongnu.org Developers" , BALATON Zoltan On 30/03/2015 13:45, Peter Crosthwaite wrote: > Can the address_space_translate_address() length clamp be made > conditional on non-MMIO access as the RC fix? I submitted > c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 as I think its the right > thing to do regardless of memory type, but in reality it only fixes a > bug I encountered with RAM memory regions. The original code ignores > address_space_translate_internal() return-by-pointer length value > absolutely and the new code uses it absolutely. Should we just if the > whole thing, old vs new behaviour on MMIO vs non-MMIO? > > Happy to submit that fixup if that's the accepted plan. I submitted what I think is the right fix (sorry Mark for misspelling your email address). I think you're patch is correct, so I'd rather not introduce hacks for the release; we can either revert it, or fix ioport.c. Paolo