All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vincent Stehlé" <vincent.stehle@freescale.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] imx6sabresd: rename to imx6sabre
Date: Mon, 30 Mar 2015 13:54:00 +0200	[thread overview]
Message-ID: <55193958.2080806@freescale.com> (raw)
In-Reply-To: <550D8D41.3080504@mind.be>

On 03/21/2015 04:24 PM, Arnout Vandecappelle wrote:
..
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Hi Arnout,

Thank you very much for reviewing!

(too big a patch)
..
> So to simplify the review, I've replaced your mail below with the result of git
> format-patch -M

Thanks for the tips. I updated my git config as per your comments; my
next patches should be better.

(create-boot-sd.sh)
..
>  Since it is also used by imx53loco, perhaps it's better to put this script in
> the freescale directory instead?

That makes sense; I will send a v2 patch with the create-boot-sd.sh
script in board/freescale/ then.

(readme.txt mentioning sabre auto)
..
>> +  - imx6dl-sabresd.dtb or imx6q-sabresd.dtb or imx6q-sabreauto.dtb or
>> +    imx6dl-sabreauto.dtb
>  The auto things are only added by the second patch...

Sorry, this is a mistake; thank you for spotting that.

Best regards,

V.

      parent reply	other threads:[~2015-03-30 11:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 17:41 [Buildroot] [PATCH 1/2] imx6sabresd: rename to imx6sabre Vincent Stehlé
2015-03-20 17:41 ` [Buildroot] [PATCH 2/2] configs: add Freescale SABRE Auto board support Vincent Stehlé
2015-03-21 15:37   ` Arnout Vandecappelle
2015-03-30 11:59     ` Vincent Stehlé
2015-03-30 12:50     ` [Buildroot] [PATCH v2 1/2] imx6sabresd: rename to imx6sabre Vincent Stehlé
2015-03-30 12:50       ` [Buildroot] [PATCH v2 2/2] configs: add Freescale SABRE Auto board support Vincent Stehlé
2015-04-01 21:35       ` [Buildroot] [PATCH v2 1/2] imx6sabresd: rename to imx6sabre Thomas Petazzoni
2015-03-21 15:24 ` [Buildroot] [PATCH " Arnout Vandecappelle
2015-03-21 16:34   ` Eric Nelson
2015-03-30 11:54   ` Vincent Stehlé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55193958.2080806@freescale.com \
    --to=vincent.stehle@freescale.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.