All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: ghammer@redhat.com, mst@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression
Date: Mon, 30 Mar 2015 14:27:05 +0200	[thread overview]
Message-ID: <55194119.5060507@redhat.com> (raw)
In-Reply-To: <1427717907-25027-1-git-send-email-imammedo@redhat.com>



On 30/03/2015 14:18, Igor Mammedov wrote:
> Commit cd61cb2  pc: acpi-build: generate pvpanic device description dynamically
> 
> introduced regression changing pvpanic device HID from
> QEMU0001 to QEMU0002.
> Fix AML generated code so that pvpanic device
> would keep its original HID. i.e. QEMU0001
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reported-by: Gal Hammer <ghammer@redhat.com>
> ---
>  hw/i386/acpi-build.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index d0a5c85..e761005 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -788,7 +788,7 @@ build_ssdt(GArray *table_data, GArray *linker,
>          scope = aml_scope("\\_SB.PCI0.ISA");
>  
>          dev = aml_device("PEVR");
> -        aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002")));
> +        aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0001")));
>  
>          crs = aml_resource_template();
>          aml_append(crs,
> 

Pretty obvious, so I can take this through my tree.

Paolo

  reply	other threads:[~2015-03-30 12:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 12:18 [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression Igor Mammedov
2015-03-30 12:27 ` Paolo Bonzini [this message]
2015-03-30 12:39   ` Igor Mammedov
2015-03-30 16:20 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55194119.5060507@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ghammer@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.