From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH 0/3] Improve dw-hdmi CTS/N setting Date: Mon, 30 Mar 2015 21:23:21 +0800 Message-ID: <55194E49.3000304@rock-chips.com> References: <20150327111320.GA4019@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150327111320.GA4019-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Russell King - ARM Linux , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Fabio Estevam , mmind00-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org, David Airlie , Greg Kroah-Hartman , dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Philipp Zabel , marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: linux-rockchip.vger.kernel.org SGkgUnVzc2VsbDoKCk9uIDIwMTXlubQwM+aciDI35pelIDE5OjEzLCBSdXNzZWxsIEtpbmcgLSBB Uk0gTGludXggd3JvdGU6Cj4gQWxsLAo+Cj4gVGhpcyBpcyBhIG1pbmktc2VyaWVzIHRvIHRyeSBh bmQgbW92ZSBhdWRpbyBzdXBwb3J0IGZvciB0aGUgRGVzaWdud2FyZQo+IEhETUkgYnJpZGdlIGFs b25nLgo+Cj4gVGhlcmUgYXJlIHR3byBrbm93biB2ZXJzaW9ucyBvZiB0aGUgRGVzaWdud2FyZSBI RE1JIGF1ZGlvOgo+Cj4gLSBUaGUgUm9ja2NoaXAgdmVyc2lvbiwgd2hpY2ggaXMgYmFzZWQgdXBv biBmZWVkaW5nIHRoZSBIRE1JIGJsb2NrIEkyUwo+ICAgIHN0cmVhbShzKSwgd2hpY2ggZG9lc24n dCBoYXZlIGFueSBvbi1ib2FyZCBETUEgc3VwcG9ydC4KPiAtIFRoZSBGcmVlc2NhbGUgdmVyc2lv biwgd2hpY2ggb25seSBoYXMgQUhCIERNQSBzdXBwb3J0Lgo+Cj4gVGhlcmUgYXJlIHR3byBkcml2 ZXJzIGFyb3VuZCBhdCBwcmVzZW50LCBvbmUgd2hpY2ggSSd2ZSBoYWQgd2hpY2ggaXMKPiBBTFNB IGJhc2VkIGR1ZSB0byBpdHMgc2ltcGxpY2l0eSBmb3IgdGhlIEZyZWVzY2FsZSB2ZXJzaW9uIG9m IHRoZSBJUCwKPiBhbmQgb25lIHdoaWNoIGlzIEFTb0MgYmFzZWQgZnJvbSBZYWtpciBZYW5nIGZv ciB0aGUgUm9ja2NoaXAgdmVyc2lvbi4KPgo+IFRoZXJlIGlzIHNvbWUgY29tbW9uYWxpdHkgYmV0 d2VlbiB0aGUgdHdvIGRyaXZlcnMgLSBmb3IgZXhhbXBsZSwgdGhlCj4gc2V0dXAgb2YgdGhlIENU Uy9OIHZhbHVlcyBpcyB2ZXJ5IHNpbWlsYXIsIGFsdGhvdWdoIG5vdCBpZGVudGljYWwuCj4KPiBJ IGhhdmUgYmVlbiByZXZpZXdpbmcgKHdoZW4gdGltZSBwZXJtaXRzKSB0aGUgcGF0Y2hlcyBmcm9t IFlha2lyIFlhbmcsCj4gYW5kIG1ha2luZyByZWNvbW1lbmRhdGlvbnMgdG8gdHJ5IGFuZCBleHRy YWN0IHRoZSBjb21tb24gcGFydHMgb2YgdGhlCj4gZHJpdmVyLiAgVGhpcyBpcyB0aGUgcGF0Y2gg c2V0IEkgY2FtZSB1cCB3aXRoIChtZW50aW9uZWQgaW4KPiAyMDE1MDIwMjEzMDkyMC5HQzg2NTZA bjIxMDAuYXJtLmxpbnV4Lm9yZy51aykuCj4KPiBZYWtpciBtZXJnZWQgc29tZSBvZiBteSBpZGVh cyBpbnRvIGhpcyBwYXRjaCBzZXQgLSBmb3IgZXhhbXBsZSwgWWFraXIKPiBZYW5nJ3MgImRybTog YnJpZGdlL2R3X2hkbWk6IGNvbWJpbmUgaGRtaV9zZXRfY2xvY2tfcmVnZW5lcmF0b3JfbigpIGFu ZAo+IGhkbWlfcmVnZW5lcmF0ZV9jdHMoKSIgaXMgdmVyeSBjbG9zZSB0byB0aGUgdmVyc2lvbiB3 aGljaCBJIGNhbWUgdXAKPiB3aXRoLgo+Cj4gWWFraXIgWWFuZyBkaWRuJ3QgaW5jbHVkZSB0aGUg bXV0ZXggcGF0Y2gsIHdoaWNoIEkndmUgaW5jbHVkZWQgaGVyZSAtCj4gaXQgcmVhbGx5IGlzIG5l Y2Vzc2FyeSBiZWNhdXNlIHdlIGhhdmUgcG90ZW50aWFsbHkgdHdvIGRpZmZlcmVudAo+IHRocmVh ZHMgd2hpY2ggY2FuIGNoYW5nZSB0aGUgQ1RTL04gdmFsdWVzIC0gYSBjaGFuZ2Ugb2YgdGhlIHZp ZGVvIG1vZGUKPiB2cyBhIGNoYW5nZSBpbiB0aGUgYXVkaW8gZHJpdmVyLgo+Cj4gVGhlIGxhc3Qg cGF0Y2ggaXMgYWRqdXN0aW5nIHRoZSBDVFMvTiBzZXR0aW5nIG9yZGVyIC0gSSBoYXZlIG9ubHkg Z29uZQo+IGFzIGZhciBhcyB3aGF0IHdlIGtub3cgd29ya3MgZm9yIGlNWDYsIGFuZCB0aGlzIGlz IGFsc28gaWRlbnRpY2FsIHRvCj4gWWFraXIgWWFuZydzIHBhdGNoLgo+Cj4gVGhlIGlkZW50aWNh bCBuYXR1cmUgaXMgaGFyZGx5IHN1cnByaXNpbmc7IG15IHBhdGNoZXMgd2VyZSBkZXJpdmVkIGZy b20KPiBhIHByZXZpb3VzIHNldCBvZiBoaXMgcGF0Y2hlcyAod2hpY2ggSSBhY2tub3dsZWRnZSBp biB0aGUgY29tbWl0IG1lc3NhZ2VzKQo+IGFuZCBJIGRldGFpbGVkIGluIHRoZSBhYm92ZSBtZXNz YWdlIHdoYXQgSSB3YW50ZWQgdG8gc2VlLgo+Cj4gV2hhdCBJIHdvdWxkIGxpa2UgdG8gc2VlIGlz IHRoYXQgLSBhcyB3ZSBhcmUgZWZmZWN0aXZlbHkgaW4gYWdyZWVtZW50Cj4gb3ZlciB0d28gb2Yg dGhlc2UgcGF0Y2hlcyAtIHdlIGdldCB0aGVzZSBwYXRjaGVzIG1lcmdlZCByYXRoZXIgdGhhbgo+ IGhhdmluZyB0byByZXBlYXRlZGx5IHNlZSB0aGVtLiAgSWYgdGhlcmUncyBhbnkgb2JqZWN0aW9u LCBwbGVhc2UgbGV0IG1lCj4ga25vdywgb3RoZXJ3aXNlIEknbGwgY29sbGVjdCBhY2tzIGFuZCBz ZW5kIHRoZW0gdG8gRGF2aWQuCj4KPiAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHdfaGRtaS5j IHwgMzQgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5n ZWQsIDE5IGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQo+CiAgIEFmdGVyIHRhbGsgd2l0 aCBZYWtpciBZYW5nLCB3ZSBhcmUgZ2xhZCB5b3VyIHN1Z2dlc3Rpb24gYW5kIHBhdGNoLgogICBB Y2tlZC1ieTogQW5keSBZYW4gPGFuZHkueWFuQHJvY2stY2hpcHMuY29tPgoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWls aW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: andy.yan@rock-chips.com (Andy Yan) Date: Mon, 30 Mar 2015 21:23:21 +0800 Subject: [PATCH 0/3] Improve dw-hdmi CTS/N setting In-Reply-To: <20150327111320.GA4019@n2100.arm.linux.org.uk> References: <20150327111320.GA4019@n2100.arm.linux.org.uk> Message-ID: <55194E49.3000304@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Russell: On 2015?03?27? 19:13, Russell King - ARM Linux wrote: > All, > > This is a mini-series to try and move audio support for the Designware > HDMI bridge along. > > There are two known versions of the Designware HDMI audio: > > - The Rockchip version, which is based upon feeding the HDMI block I2S > stream(s), which doesn't have any on-board DMA support. > - The Freescale version, which only has AHB DMA support. > > There are two drivers around at present, one which I've had which is > ALSA based due to its simplicity for the Freescale version of the IP, > and one which is ASoC based from Yakir Yang for the Rockchip version. > > There is some commonality between the two drivers - for example, the > setup of the CTS/N values is very similar, although not identical. > > I have been reviewing (when time permits) the patches from Yakir Yang, > and making recommendations to try and extract the common parts of the > driver. This is the patch set I came up with (mentioned in > 20150202130920.GC8656 at n2100.arm.linux.org.uk). > > Yakir merged some of my ideas into his patch set - for example, Yakir > Yang's "drm: bridge/dw_hdmi: combine hdmi_set_clock_regenerator_n() and > hdmi_regenerate_cts()" is very close to the version which I came up > with. > > Yakir Yang didn't include the mutex patch, which I've included here - > it really is necessary because we have potentially two different > threads which can change the CTS/N values - a change of the video mode > vs a change in the audio driver. > > The last patch is adjusting the CTS/N setting order - I have only gone > as far as what we know works for iMX6, and this is also identical to > Yakir Yang's patch. > > The identical nature is hardly surprising; my patches were derived from > a previous set of his patches (which I acknowledge in the commit messages) > and I detailed in the above message what I wanted to see. > > What I would like to see is that - as we are effectively in agreement > over two of these patches - we get these patches merged rather than > having to repeatedly see them. If there's any objection, please let me > know, otherwise I'll collect acks and send them to David. > > drivers/gpu/drm/bridge/dw_hdmi.c | 34 +++++++++++++++++++--------------- > 1 file changed, 19 insertions(+), 15 deletions(-) > After talk with Yakir Yang, we are glad your suggestion and patch. Acked-by: Andy Yan