From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v5 08/15] xen: arm: drop cache maintenance by set/way trap handling Date: Mon, 30 Mar 2015 14:59:59 +0100 Message-ID: <551956DF.8010609@linaro.org> References: <1427713930.13935.287.camel@citrix.com> <1427713955-15657-8-git-send-email-ian.campbell@citrix.com> <55194179.10206@linaro.org> <1427721355.13935.292.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1427721355.13935.292.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 30/03/15 14:15, Ian Campbell wrote: > On Mon, 2015-03-30 at 13:28 +0100, Julien Grall wrote: >> Hi Ian, >> >> On 30/03/15 12:12, Ian Campbell wrote: >>> We do not set HCR_EL2.TSW so we will never see these. >>> >>> This is undoubtedly wrong, but for now remove the dead code. >> >> Would it be better to trap and ignore them? > > Yes, but this patch retains the status quo (while removing a thing to > think about in later patches). Doing something better is on my todo list > (as I said in the cover letter). Ok. Based on this: Reviewed-by: Julien Grall With that, I think I review all this series. Regards, -- Julien Grall