From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] tools/hvmloader: Don't perform AML hotplug debugging in production Date: Mon, 30 Mar 2015 16:30:01 +0100 Message-ID: <55196BF9.2090905@citrix.com> References: <1427725219-21376-1-git-send-email-andrew.cooper3@citrix.com> <20150330152229.GD31851@l.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150330152229.GD31851@l.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Keir Fraser , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org On 30/03/15 16:22, Konrad Rzeszutek Wilk wrote: > On Mon, Mar 30, 2015 at 03:20:19PM +0100, Andrew Cooper wrote: >> It is number of vmexits and a moderate quantity of qemu logging which can >> safely be avoided when not specifically debugging a PCI hotplug issue. > Could we just make qemu-X not include this data when the we > run in production? And in the field if this needs to be diagnosed > we can just pass in an extra flag to QEMU and it would do it? What do we not include? This is data which gets bundled into hvmloader itself. A little while ago, I proposed a different solution: http://lists.xen.org/archives/html/xen-devel/2014-01/msg01526.html which allowed this to all be controlled at runtime. The important point is to avoid the vmexits if not needed, rather than to simply ignore the debugging they are giving. ~Andrew