From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcdoS-00061e-2g for qemu-devel@nongnu.org; Mon, 30 Mar 2015 13:49:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcdoQ-0001j7-UZ for qemu-devel@nongnu.org; Mon, 30 Mar 2015 13:49:24 -0400 Message-ID: <55198C9A.4030908@suse.de> Date: Mon, 30 Mar 2015 19:49:14 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1427651603-9210-1-git-send-email-afaerber@suse.de> In-Reply-To: <1427651603-9210-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-block@nongnu.org, "Michael S. Tsirkin" , mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, armbru@redhat.com, qemu-ppc@nongnu.org, Paolo Bonzini , hpoussin@reactos.org, jsnow@redhat.com David, Am 29.03.2015 um 19:53 schrieb Andreas F=C3=A4rber: > Hello Markus et al., >=20 > This series attempts to fix the -device pc87312 issues you reported. >=20 > I can't add alias properties for devices that don't get created before = realize. > Therefore this involves moving code for various ISA devices, to enable = us > to initialize the objects early for alias properties and realizing them > as part of the composite device once the configuration is known, also f= ixing > error propagation while at it. Probably needs a further iteration. >=20 > Yes, it's terribly invasive, that's why the code was as it is. > But the code movements are quite trivial, as long as no in-air conflict= s occur. Could you take a look whether or where these proposed ISA code movements conflict with your ISA config series? Might we need to introduce separate -isa headers here? Thanks, Andreas >=20 > A follow-up would be to respin my old ISA enabled/disabled series to al= low > inactive ISADevices sitting on an ISABus. >=20 > Regards, > Andreas >=20 > Cc: Markus Armbruster > Cc: Herv=C3=A9 Poussineau > Cc: qemu-ppc@nongnu.org > Cc: qemu-block@nongnu.org > Cc: John Snow >=20 > Andreas F=C3=A4rber (8): > parallel: Factor out header for ISAParallelState struct > pc87312: Create isa-parallel in-place and add alias par0-chardev > property > serial: Move ISASerialState to header > pc87312: Create UARTs in-place and add alias properties > fdb: Move FDCtrlISABus to header > pc87312: Create FDC in-place > ide: Move ISAIDEState to header > pc87312: Create IDE in-place >=20 > hw/block/fdc.c | 87 ----------------------- > hw/char/parallel.c | 30 +------- > hw/char/serial-isa.c | 12 ---- > hw/ide/internal.h | 155 -------------------------------------= --- > hw/ide/isa.c | 13 ---- > hw/isa/pc87312.c | 107 ++++++++++++++++------------ > hw/ppc/prep.c | 33 +++++++++ > include/hw/block/fdc.h | 88 +++++++++++++++++++++++ > include/hw/char/parallel.h | 62 ++++++++++++++++ > include/hw/char/serial.h | 14 ++++ > include/hw/ide.h | 173 +++++++++++++++++++++++++++++++++++++= ++++++++ > include/hw/isa/pc87312.h | 23 +++--- > 12 files changed, 442 insertions(+), 355 deletions(-) > create mode 100644 include/hw/char/parallel.h >=20 --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)