From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Nadav Amit <namit@cs.technion.ac.il>,
mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable
Date: Mon, 30 Mar 2015 21:37:13 +0200 [thread overview]
Message-ID: <5519A5E9.7090706@redhat.com> (raw)
In-Reply-To: <68F69D11-D45C-497D-B51B-9D85BA2F5891@gmail.com>
On 30/03/2015 21:31, Nadav Amit wrote:
> > Because QEMU support for INIT is incomplete, so the tests would fail
> > ("Uh, hard reset!"). IIRC sending init to BSP with APIC_DEST_SELF is
> > also not supported by actual hardware (or at least not supported
> > "officially") so that test would also have to be changed to not use a
> > shortcut.
>
> So, I would revive the init unit-test and disable the failing assertions,
> right?
Yes, or otherwise mark them as expected failures so that they do not
affect the exit code.
Paolo
> BTW: It appears that there is another bug - DR[0..3] are not reloaded after
> reset.
next prev parent reply other threads:[~2015-03-30 19:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 12:39 [PATCH 0/5] KVM: x86: 64/32 bit fixes and INIT/BSP fixes Nadav Amit
2015-03-30 12:39 ` [PATCH 1/5] KVM: x86: CMOV emulation on legacy mode is wrong Nadav Amit
2015-03-30 12:39 ` [PATCH 2/5] KVM: x86: POPA emulation may not clear bits [63:32] Nadav Amit
2015-03-30 12:39 ` [PATCH 3/5] KVM: x86: BSF and BSR emulation change register unnecassarily Nadav Amit
2015-03-30 12:39 ` [PATCH 4/5] KVM: x86: INIT and reset sequences are different Nadav Amit
2015-03-30 12:39 ` [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable Nadav Amit
2015-03-30 14:12 ` Paolo Bonzini
2015-03-30 14:40 ` Nadav Amit
2015-03-30 14:45 ` Paolo Bonzini
2015-03-30 19:31 ` Nadav Amit
2015-03-30 19:37 ` Paolo Bonzini [this message]
2015-03-30 14:46 ` [PATCH 0/5] KVM: x86: 64/32 bit fixes and INIT/BSP fixes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5519A5E9.7090706@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=namit@cs.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.