From: "Andreas Färber" <afaerber@suse.de>
To: David Gibson <david@gibson.dropbear.id.au>,
agraf@suse.de, mst@redhat.com, andreas.faerber@web.de,
lcapitulino@redhat.com
Cc: blauwirbel@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/6] pc: Use MachineClass callbacks for "irq" and "pic" hmp commands
Date: Mon, 30 Mar 2015 23:47:27 +0200 [thread overview]
Message-ID: <5519C46F.5050309@suse.de> (raw)
In-Reply-To: <1425615506-1829-4-git-send-email-david@gibson.dropbear.id.au>
Am 06.03.2015 um 05:18 schrieb David Gibson:
> Currently PC machine types rely on fallback code in the monitor
> implementation to correctly implement these hmp commands. Now that we have
> MachineClass callbacks to control this properly, instantiate them in
> pc_generic_machine_class_init().
>
> Since this sets the MachineClass callbacks correctly for all x86 machine
> types, we can now remove the TARGET_I386 fallback case from the monitor
> code.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-03-30 21:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 4:18 [Qemu-devel] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build David Gibson
2015-03-06 4:18 ` [Qemu-devel] [PATCH 1/6] Split serial-isa into its own config option David Gibson
2015-03-30 7:28 ` Markus Armbruster
2015-03-31 5:36 ` David Gibson
2015-03-06 4:18 ` [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259 David Gibson
2015-03-30 7:49 ` Markus Armbruster
2015-03-30 8:37 ` Markus Armbruster
2015-03-31 0:05 ` David Gibson
2015-03-31 9:57 ` Markus Armbruster
2015-04-01 0:40 ` David Gibson
2015-03-30 21:41 ` Andreas Färber
2015-03-31 10:07 ` Peter Maydell
2015-03-06 4:18 ` [Qemu-devel] [PATCH 3/6] pc: Use MachineClass callbacks for "irq" and "pic" hmp commands David Gibson
2015-03-30 21:47 ` Andreas Färber [this message]
2015-03-06 4:18 ` [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class David Gibson
2015-03-30 21:33 ` Andreas Färber
2015-03-31 5:40 ` David Gibson
2015-03-06 4:18 ` [Qemu-devel] [PATCH 5/6] prep: Use MachineClass callbacks for "irq" and "pic" hmp commands David Gibson
2015-03-30 21:25 ` Andreas Färber
2015-03-06 4:18 ` [Qemu-devel] [PATCH 6/6] Allow ISA bus to be configured out David Gibson
2015-03-06 11:41 ` [Qemu-devel] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build Alexander Graf
2015-03-10 14:20 ` Michael S. Tsirkin
2015-03-10 14:56 ` Luiz Capitulino
2015-03-30 2:41 ` David Gibson
2015-03-30 8:48 ` Markus Armbruster
2015-03-30 17:45 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5519C46F.5050309@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=andreas.faerber@web.de \
--cc=blauwirbel@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=lcapitulino@redhat.com \
--cc=michael@walle.cc \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.