From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753354AbbCaJMA (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 Mar 2015 05:12:00 -0400
Received: from mga11.intel.com ([192.55.52.93]:29995 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753166AbbCaJL5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 Mar 2015 05:11:57 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,499,1422950400"; 
   d="scan'208";a="706616415"
Message-ID: <551A645F.4000504@intel.com>
Date: Tue, 31 Mar 2015 12:09:51 +0300
From: Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki 
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Jiri Olsa <jolsa@redhat.com>
CC: Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Namhyung Kim <namhyung@gmail.com>, Paul Mackerras <paulus@samba.org>,
        Stephane Eranian <eranian@google.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH V6 02/25] perf evlist: Add initial support for mmapping
 an AUX area buffer
References: <1426509707-24961-1-git-send-email-adrian.hunter@intel.com> <1426509707-24961-3-git-send-email-adrian.hunter@intel.com> <20150324110746.GE27134@krava.brq.redhat.com>
In-Reply-To: <20150324110746.GE27134@krava.brq.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24/03/15 13:07, Jiri Olsa wrote:
> On Mon, Mar 16, 2015 at 02:41:24PM +0200, Adrian Hunter wrote:
> 
> SNIP
> 
>> index 8d0b623..3cc7815 100644
>> --- a/tools/perf/util/evlist.c
>> +++ b/tools/perf/util/evlist.c
>> @@ -725,6 +725,34 @@ void perf_evlist__mmap_consume(struct perf_evlist *evlist, int idx)
>>  		perf_evlist__mmap_put(evlist, idx);
>>  }
>>  
>> +int __weak auxtrace_mmap__mmap(struct auxtrace_mmap *mm __maybe_unused,
>> +			       struct auxtrace_mmap_params *mp __maybe_unused,
>> +			       void *userpg __maybe_unused,
>> +			       int fd __maybe_unused)
>> +{
>> +	return 0;
>> +}
>> +
>> +void __weak auxtrace_mmap__munmap(struct auxtrace_mmap *mm __maybe_unused)
>> +{
>> +}
>> +
>> +void __weak auxtrace_mmap_params__init(
>> +			struct auxtrace_mmap_params *mp __maybe_unused,
>> +			off_t auxtrace_offset __maybe_unused,
>> +			unsigned int auxtrace_pages __maybe_unused,
>> +			bool auxtrace_overwrite __maybe_unused)
>> +{
>> +}
>> +
>> +void __weak auxtrace_mmap_params__set_idx(
>> +			struct auxtrace_mmap_params *mp __maybe_unused,
>> +			struct perf_evlist *evlist __maybe_unused,
>> +			int idx __maybe_unused,
>> +			bool per_cpu __maybe_unused)
>> +{
>> +}
> 
> IMO it's better to place the weak auxtrace_* functions in auxtrace header

They are there for python extension linking.