From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcuCk-0008AZ-C2 for qemu-devel@nongnu.org; Tue, 31 Mar 2015 07:19:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcuCf-0000gn-CD for qemu-devel@nongnu.org; Tue, 31 Mar 2015 07:19:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58533 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcuCf-0000ga-5R for qemu-devel@nongnu.org; Tue, 31 Mar 2015 07:19:29 -0400 Message-ID: <551A82BD.8010604@suse.de> Date: Tue, 31 Mar 2015 13:19:25 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1427715918-25768-1-git-send-email-pbonzini@redhat.com> <1427715918-25768-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1427715918-25768-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.3 1/6] sb16: remove useless mixer_write_indexw List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Mark Cave-Ayland Am 30.03.2015 um 13:45 schrieb Paolo Bonzini: > ioport.c is already able to split a 16-bit access into two 8-bit > accesses to consecutive ports. Tested with Epic Pinball. >=20 > Signed-off-by: Paolo Bonzini > --- > hw/audio/sb16.c | 7 ------- > 1 file changed, 7 deletions(-) >=20 > diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c > index 444eb9e..b052de5 100644 > --- a/hw/audio/sb16.c > +++ b/hw/audio/sb16.c > @@ -1121,12 +1121,6 @@ static IO_WRITE_PROTO (mixer_write_datab) > s->mixer_regs[s->mixer_nreg] =3D val; > } > =20 > -static IO_WRITE_PROTO (mixer_write_indexw) > -{ > - mixer_write_indexb (opaque, nport, val & 0xff); > - mixer_write_datab (opaque, nport, (val >> 8) & 0xff); > -} I assume you've verified the endianness handling, too? Reviewed-by: Andreas F=E4rber Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)