From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 17/33] xen/arm: vgic: Add spi_to_pending Date: Tue, 31 Mar 2015 12:58:20 +0100 Message-ID: <551A8BDC.30101@linaro.org> References: <1426793399-6283-1-git-send-email-julien.grall@linaro.org> <1426793399-6283-18-git-send-email-julien.grall@linaro.org> <1427799343.2115.63.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ycuoj-0006T2-2V for xen-devel@lists.xenproject.org; Tue, 31 Mar 2015 11:58:49 +0000 Received: by widdi4 with SMTP id di4so6210796wid.0 for ; Tue, 31 Mar 2015 04:58:47 -0700 (PDT) In-Reply-To: <1427799343.2115.63.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 31/03/15 11:55, Ian Campbell wrote: > On Thu, 2015-03-19 at 19:29 +0000, Julien Grall wrote: >> Introduce spi_to_pending in order retrieve the irq_pending structure for >> a specific SPI. >> >> It's not possible to re-use irq_to_pending because it's required a VCPU > > "it requires" > >> and some call of the new function may during domain destruction after >> the VCPUs are freed. >> >> Signed-off-by: Julien Grall > > Acked-by: Ian Campbell Thanks. > Although given the name I would expect it to take an spi (i.e. -32) not > an irq. I can't think of a better name though and perhaps that just > makes things harder for the caller.. It depends if you think relative or absolute. In this case, the absolute value is easier to use. FWIW, we already have SPI-specific function using absolute value. Regards, -- Julien Grall