From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id A8C79E0092E; Tue, 31 Mar 2015 07:10:44 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.180 listed in list.dnswl.org] Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 4817FE008D4 for ; Tue, 31 Mar 2015 07:10:42 -0700 (PDT) Received: by wiaa2 with SMTP id a2so27724197wia.0 for ; Tue, 31 Mar 2015 07:10:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=ExWvChtXBGyAB1e6vyjLZOExBCk0/z0cbNcTBrHCKaI=; b=fh9xiWuZrD2M8dgQ1LAewEMfvyOc/4nUDZRJJ6vpd9tlVfxVq5Xowz5B2Ql6vdwIZm I6GejpC3Bq0401Cg53GfjUsOKVk4zTMAb2YVDkHpCP4RaZp77XJxaZvolejC0Gypu6qa IbJnNIJm5+4fy1RlBPrXjgGvw/18SiyN+OSOefFYv7NPvr5J8fhq14gmGhiFHg2Ca7Yn 6fJ7159YUrcaij99gIaFYlTc5ZAk5KRPJMicUGQL2hc3aMYmrOjbWAOMbhzgILKvKiJt FmO5gUGAFoJfI+RcZd52AT6BrF+/teCcb+Kle/W6bPwh5YKbvCgFDtGKipwsCViDWtiu Iulw== X-Gm-Message-State: ALoCoQl8vH0yMYUMx8A4w0yvyt1jg7xFR1mJfmC5kTeglkc5ii+4/9BUWMqRsn5+HjX9yZP5lpAl X-Received: by 10.180.75.233 with SMTP id f9mr5785232wiw.5.1427811040830; Tue, 31 Mar 2015 07:10:40 -0700 (PDT) Received: from [192.168.2.75] ([83.217.123.106]) by mx.google.com with ESMTPSA id k6sm21128481wia.6.2015.03.31.07.10.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Mar 2015 07:10:40 -0700 (PDT) Message-ID: <551AAADE.8070308@intel.com> Date: Tue, 31 Mar 2015 15:10:38 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Reyna, David" , "BARROS PENA, BELEN" , "DAMIAN, ALEXANDRU" References: <5E53D14CE4667A45B9A06760DE5D13D07789881F@ALA-MBA.corp.ad.wrs.com> In-Reply-To: <5E53D14CE4667A45B9A06760DE5D13D07789881F@ALA-MBA.corp.ad.wrs.com> Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] dreyna/projects_pagecount_7483 X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2015 14:10:44 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Looks good to me. [These are the kind of bugs I'm hoping will go away with RFC ToasterTable!] On 31/03/15 02:36, Reyna, David wrote: > Hi Belén and Michael, > > I went ahead and grabbed (and solved) 7483 "Searching in the all projects table resets the 'show rows' menu to '10'" since it was still in the new state. > > dreyna/projects_pagecount_7483 > > The "count" value for the all projects page was not fully saved in the cookies because the view class did not end with a '_save_parameters_cookies'. > > The intermediate cookie "_count" was there (from basetable_bottom.html) which is why it kind of worked, but that is not used when a search is issued. > > - David >